fix(openai-agents): capture system instructions from Response object (#4188)#3
Closed
nagkumar91 wants to merge 1 commit into
Closed
fix(openai-agents): capture system instructions from Response object (#4188)#3nagkumar91 wants to merge 1 commit into
nagkumar91 wants to merge 1 commit into
Conversation
…pen-telemetry#4188) When using the Responses API, instructions are passed separately and stored on response.instructions rather than as role="system" input messages. This adds a fallback to read response.instructions for gen_ai.system_instructions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nagkumar91
force-pushed
the
fix/4188-system-instructions
branch
from
efd0b89 to
13a0834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes open-telemetry#4188 - System prompt/instructions do not show in trace when using the Responses API.
Problem
When using the Responses API (default in OpenAI Agents SDK), agent instructions are passed as the
instructionsparameter toresponses.create(), not asrole: "system"messages in the input. TheResponseobject has an.instructionsattribute, but_collect_system_instructions()only looks for system/AI role messages in input, so instructions were never captured in the trace.Fix
Added a fallback in
_build_content_payload()for theResponseSpanDatabranch: after the existing system instruction collection from input messages, if no instructions were found, readresponse.instructionsand emit it asgen_ai.system_instructions.Changes
ResponseSpanDatabranch of_build_content_payload()inputfield toResponseSpanDatastub andMCPListToolsSpanDatastub (needed for test imports)test_response_span_instructions_fallbacktest verifying instructions fromresponse.instructionsappear in span attributes