Add crash reporting for notification failures

Author: nakorndev

AGENTS.md

@@ -41,5 +41,6 @@
 - Prefer the smallest clean change for each step.
 - Use local prototypes to validate risky platform behavior before building larger abstractions.
 - Use `scripts/run-dev.ps1` as the simple local run entrypoint and `scripts/run-build.ps1` as the simple build entrypoint.
+- Current dev and release builds share the same singleton mutex, AppUserModelID, Start Menu shortcut, settings path, and startup Run key. Do not assume they can run side by side until a separate dev identity is intentionally added.
 - Do not introduce unrelated product scope such as cloud sync, accounts, or cross-platform support unless explicitly requested.
 - Do not run builds, tests, browser checks, or packaging commands by default after normal edits unless the user asks or the change is high-risk.

App.xaml.cs

@@ -17,6 +17,7 @@ public partial class App : System.Windows.Application
 
     protected override void OnStartup(StartupEventArgs e)
     {
+        CrashReporter.Install(this);
         base.OnStartup(e);
 
         singleInstanceGuard = new SingleInstanceGuard();

CrashReporter.cs

@@ -0,0 +1,101 @@
+using System.IO;
+using System.Runtime.ExceptionServices;
+using System.Text;
+using System.Threading;
+using System.Threading.Tasks;
+using System.Windows;
+
+namespace ToastDesk;
+
+public static class CrashReporter
+{
+    private static int isShowingCrash;
+
+    public static void Install(System.Windows.Application application)
+    {
+        application.DispatcherUnhandledException += (_, args) =>
+        {
+            ShowFatalException(args.Exception);
+            args.Handled = true;
+            application.Shutdown(-1);
+        };
+
+        AppDomain.CurrentDomain.UnhandledException += (_, args) =>
+        {
+            var exception = args.ExceptionObject as Exception
+                ?? new InvalidOperationException($"Unhandled non-Exception object: {args.ExceptionObject}");
+            ShowFatalException(exception);
+        };
+
+        TaskScheduler.UnobservedTaskException += (_, args) =>
+        {
+            ShowFatalException(args.Exception);
+            args.SetObserved();
+            application.Dispatcher.InvokeAsync(() => application.Shutdown(-1));
+        };
+    }
+
+    public static string FormatExceptionSummary(Exception exception)
+    {
+        var exceptionInfo = ExceptionDispatchInfo.Capture(exception).SourceException;
+        return $"{exceptionInfo.GetType().FullName} (HRESULT 0x{exceptionInfo.HResult:X8}): {exceptionInfo.Message}";
+    }
+
+    private static void ShowFatalException(Exception exception)
+    {
+        if (Interlocked.Exchange(ref isShowingCrash, 1) == 1)
+        {
+            return;
+        }
+
+        try
+        {
+            WriteCrashLog(exception);
+            System.Windows.MessageBox.Show(
+                BuildCrashMessage(exception),
+                "ToastDesk crashed",
+                MessageBoxButton.OK,
+                MessageBoxImage.Error,
+                MessageBoxResult.OK,
+                System.Windows.MessageBoxOptions.DefaultDesktopOnly);
+        }
+        finally
+        {
+            Interlocked.Exchange(ref isShowingCrash, 0);
+        }
+    }
+
+    private static string BuildCrashMessage(Exception exception)
+    {
+        var builder = new StringBuilder();
+        builder.AppendLine("ToastDesk hit an unhandled error and must close.");
+        builder.AppendLine();
+        builder.AppendLine(FormatExceptionSummary(exception));
+        builder.AppendLine();
+        builder.AppendLine($"Source: {exception.Source ?? "Unknown"}");
+        builder.AppendLine($"Target: {exception.TargetSite?.Name ?? "Unknown"}");
+        builder.AppendLine();
+        builder.AppendLine("Stack trace:");
+        builder.AppendLine(exception.ToString());
+        builder.AppendLine();
+        builder.AppendLine($"A copy was written to: {GetCrashLogPath()}");
+        return builder.ToString();
+    }
+
+    private static void WriteCrashLog(Exception exception)
+    {
+        var logPath = GetCrashLogPath();
+        Directory.CreateDirectory(Path.GetDirectoryName(logPath)!);
+        File.WriteAllText(
+            logPath,
+            $"{DateTimeOffset.Now:O}{Environment.NewLine}{BuildCrashMessage(exception)}");
+    }
+
+    private static string GetCrashLogPath()
+    {
+        return Path.Combine(
+            Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
+            "ToastDesk",
+            "crash-last.log");
+    }
+}

README.md

@@ -72,6 +72,25 @@ The local packages are written to `artifacts/release`.
 powershell -ExecutionPolicy Bypass -File .\scripts\run-dev.ps1
 ```
 
+## Local Testing With An Installed Release
+
+The installed release and a local dev build currently use the same ToastDesk identity. They share the single-instance mutex, AppUserModelID, Start Menu shortcut, settings folder, and Windows startup Run key.
+
+You do not need to uninstall the released app for normal local testing, but you should exit ToastDesk from the tray before starting a dev build. If **Start with Windows** is enabled while running a dev build, the startup entry can point at the dev executable. Turn that setting off for dev testing, or turn it back on from the installed release afterward.
+
+For installer-like testing on the same PC:
+
+1. Exit the installed ToastDesk tray app.
+2. Build a portable release with:
+
+```powershell
+powershell -ExecutionPolicy Bypass -File .\scripts\publish-release.ps1 -SkipInstallers
+```
+
+3. Run `artifacts\publish\win-x64\ToastDesk.exe`.
+
+For true side-by-side testing while the released app keeps running in the background, use a VM/Windows Sandbox or add a separate dev identity first.
+
 ## Build
 
 ```powershell

WindowsNotificationListener.cs

@@ -239,19 +239,30 @@ private async Task<IReadOnlyList<UserNotification>> GetCurrentNotificationsAsync
 
     private static NotificationDetails ExtractDetails(UserNotification notification)
     {
-        var binding = notification.Notification.Visual.GetBinding(KnownNotificationBindings.ToastGeneric);
-        var textElements = binding?.GetTextElements().Select(item => item.Text).Where(text => !string.IsNullOrWhiteSpace(text)).ToArray() ?? [];
-        var sourceAppName = notification.AppInfo?.DisplayInfo.DisplayName;
-        var sourceAppUserModelId = notification.AppInfo?.AppUserModelId;
-
-        var (title, message) = textElements.Length switch
+        try
         {
-            0 => ("Windows notification", $"Notification ID {notification.Id}"),
-            1 => (textElements[0], $"Notification ID {notification.Id}"),
-            _ => (textElements[0], string.Join(Environment.NewLine, textElements.Skip(1)))
-        };
+            var binding = notification.Notification.Visual.GetBinding(KnownNotificationBindings.ToastGeneric);
+            var textElements = binding?.GetTextElements().Select(item => item.Text).Where(text => !string.IsNullOrWhiteSpace(text)).ToArray() ?? [];
+            var sourceAppName = notification.AppInfo?.DisplayInfo.DisplayName;
+            var sourceAppUserModelId = notification.AppInfo?.AppUserModelId;
+
+            var (title, message) = textElements.Length switch
+            {
+                0 => ("Windows notification", $"Notification ID {notification.Id}"),
+                1 => (textElements[0], $"Notification ID {notification.Id}"),
+                _ => (textElements[0], string.Join(Environment.NewLine, textElements.Skip(1)))
+            };
 
-        return new NotificationDetails(title, message, sourceAppName, sourceAppUserModelId);
+            return new NotificationDetails(title, message, sourceAppName, sourceAppUserModelId);
+        }
+        catch (Exception ex) when (ex is COMException or InvalidOperationException or NullReferenceException)
+        {
+            return new NotificationDetails(
+                "Unsupported Windows notification skipped",
+                $"ToastDesk could not read notification ID {notification.Id}.{Environment.NewLine}{CrashReporter.FormatExceptionSummary(ex)}",
+                null,
+                null);
+        }
     }
 
     private sealed record NotificationDetails(