Apply AI agent feedback

Author: tk-o

packages/ensnode-sdk/src/ensapi/api/name-tokens/prerequisites.ts

@@ -16,7 +16,7 @@ export const nameTokensPrerequisites = Object.freeze({
   requiredPlugins: [PluginName.Registrars, PluginName.TokenScope] as const,
 
   /**
-   * Check if provided ENSApiPublicConfig supports the Name Tokens API.
+   * Check if provided EnsIndexerPublicConfig supports the Name Tokens API.
    */
   hasEnsIndexerConfigSupport(config: EnsIndexerPublicConfig): boolean {
     return nameTokensPrerequisites.requiredPlugins.every((plugin) =>

packages/ensnode-sdk/src/ensapi/api/registrar-actions/prerequisites.ts

@@ -27,7 +27,7 @@ export const registrarActionsPrerequisites = Object.freeze({
   ] as const,
 
   /**
-   * Check if provided ENSApiPublicConfig supports the Registrar Actions API.
+   * Check if provided EnsIndexerPublicConfig supports the Registrar Actions API.
    */
   hasEnsIndexerConfigSupport(config: EnsIndexerPublicConfig): boolean {
     return registrarActionsPrerequisites.requiredPlugins.every((plugin) =>

packages/ensnode-sdk/src/ensapi/client.test.ts

@@ -449,7 +449,7 @@ describe("EnsApiClient", () => {
 
       const client = new EnsApiClient();
 
-      await expect(client.config()).rejects.toThrow(/Fetching ENSNode Config Failed/i);
+      await expect(client.config()).rejects.toThrow(/Fetching ENSApi Config Failed/i);
     });
   });
 
@@ -479,7 +479,7 @@ describe("EnsApiClient", () => {
 
       // act & assert
       await expect(client.indexingStatus()).rejects.toThrow(
-        /Fetching ENSNode Indexing Status Failed/i,
+        /Fetching ENSApi Indexing Status Failed/i,
       );
     });
   });

packages/ensnode-sdk/src/ensapi/client.ts

@@ -1,13 +1,13 @@
 import type { ResolverRecordsSelection } from "../resolution";
 import {
-  type ConfigResponse,
-  deserializeConfigResponse,
   deserializedNameTokensResponse,
+  deserializeEnsApiConfigResponse,
+  deserializeEnsApiIndexingStatusResponse,
   deserializeErrorResponse,
-  deserializeIndexingStatusResponse,
   deserializeRegistrarActionsResponse,
+  type EnsApiConfigResponse,
+  type EnsApiIndexingStatusResponse,
   type ErrorResponse,
-  type IndexingStatusResponse,
   type NameTokensRequest,
   type NameTokensResponse,
   type RegistrarActionsFilter,
@@ -22,8 +22,8 @@ import {
   type ResolvePrimaryNamesResponse,
   type ResolveRecordsRequest,
   type ResolveRecordsResponse,
-  type SerializedConfigResponse,
-  type SerializedIndexingStatusResponse,
+  type SerializedEnsApiConfigResponse,
+  type SerializedEnsApiIndexingStatusResponse,
   type SerializedNameTokensResponse,
   type SerializedRegistrarActionsResponse,
 } from "./api";
@@ -304,22 +304,22 @@ export class EnsApiClient {
   }
 
   /**
-   * Fetch ENSNode Config
+   * Fetch ENSApi Config
    *
-   * Fetch the ENSNode's configuration.
+   * Fetch the ENSApi's configuration.
    *
-   * @returns {ConfigResponse}
+   * @returns {EnsApiConfigResponse}
    *
-   * @throws if the ENSNode request fails
-   * @throws if the ENSNode API returns an error response
-   * @throws if the ENSNode response breaks required invariants
+   * @throws if the ENSApi request fails
+   * @throws if the ENSApi returns an error response
+   * @throws if the ENSApi response breaks required invariants
    */
-  async config(): Promise<ConfigResponse> {
+  async config(): Promise<EnsApiConfigResponse> {
     const url = new URL(`/api/config`, this.options.url);
 
     const response = await fetch(url);
 
-    // ENSNode API should always allow parsing a response as JSON object.
+    // ENSApi should always allow parsing a response as JSON object.
     // If for some reason it's not the case, throw an error.
     let responseData: unknown;
     try {
@@ -330,27 +330,27 @@ export class EnsApiClient {
 
     if (!response.ok) {
       const errorResponse = deserializeErrorResponse(responseData);
-      throw new Error(`Fetching ENSNode Config Failed: ${errorResponse.message}`);
+      throw new Error(`Fetching ENSApi Config Failed: ${errorResponse.message}`);
     }
 
-    return deserializeConfigResponse(responseData as SerializedConfigResponse);
+    return deserializeEnsApiConfigResponse(responseData as SerializedEnsApiConfigResponse);
   }
 
   /**
-   * Fetch ENSNode Indexing Status
+   * Fetch ENSApi Indexing Status
    *
-   * @returns {IndexingStatusResponse}
+   * @returns {EnsApiIndexingStatusResponse}
    *
-   * @throws if the ENSNode request fails
-   * @throws if the ENSNode API returns an error response
-   * @throws if the ENSNode response breaks required invariants
+   * @throws if the ENSApi request fails
+   * @throws if the ENSApi returns an error response
+   * @throws if the ENSApi response breaks required invariants
    */
-  async indexingStatus(): Promise<IndexingStatusResponse> {
+  async indexingStatus(): Promise<EnsApiIndexingStatusResponse> {
     const url = new URL(`/api/indexing-status`, this.options.url);
 
     const response = await fetch(url);
 
-    // ENSNode API should always allow parsing a response as JSON object.
+    // ENSApi should always allow parsing a response as JSON object.
     // If for some reason it's not the case, throw an error.
     let responseData: unknown;
     try {
@@ -374,11 +374,13 @@ export class EnsApiClient {
       // however, if errorResponse was defined,
       // throw an error with the generic server error message
       if (typeof errorResponse !== "undefined") {
-        throw new Error(`Fetching ENSNode Indexing Status Failed: ${errorResponse.message}`);
+        throw new Error(`Fetching ENSApi Indexing Status Failed: ${errorResponse.message}`);
       }
     }
 
-    return deserializeIndexingStatusResponse(responseData as SerializedIndexingStatusResponse);
+    return deserializeEnsApiIndexingStatusResponse(
+      responseData as SerializedEnsApiIndexingStatusResponse,
+    );
   }
 
   /**

packages/ensnode-sdk/src/ensindexer/config/zod-schemas.test.ts

@@ -4,8 +4,8 @@ import { prettifyError, type ZodSafeParseResult } from "zod/v4";
 import { type EnsIndexerVersionInfo, PluginName } from "./types";
 import {
   makeDatabaseSchemaNameSchema,
-  makeENSIndexerPublicConfigSchema,
-  makeENSIndexerVersionInfoSchema,
+  makeEnsIndexerPublicConfigSchema,
+  makeEnsIndexerVersionInfoSchema,
   makeFullyPinnedLabelSetSchema,
   makeIndexedChainIdsSchema,
   makePluginsListSchema,
@@ -101,7 +101,7 @@ describe("ENSIndexer: Config", () => {
 
       it("can parse version info values", () => {
         expect(
-          makeENSIndexerVersionInfoSchema().parse({
+          makeEnsIndexerVersionInfoSchema().parse({
             nodejs: "v22.22.22",
             ponder: "0.11.25",
             ensDb: "0.32.0",
@@ -122,7 +122,7 @@ describe("ENSIndexer: Config", () => {
 
         expect(
           formatParseError(
-            makeENSIndexerVersionInfoSchema().safeParse({
+            makeEnsIndexerVersionInfoSchema().safeParse({
               nodejs: "",
               ponder: "",
               ensDb: "",
@@ -170,7 +170,7 @@ describe("ENSIndexer: Config", () => {
           } satisfies EnsIndexerVersionInfo,
         };
 
-        const parsedConfig = makeENSIndexerPublicConfigSchema().parse(validConfig);
+        const parsedConfig = makeEnsIndexerPublicConfigSchema().parse(validConfig);
 
         // The schema transforms URLs and arrays, so we need to check the transformed values
         expect(parsedConfig.indexedChainIds).toBeInstanceOf(Set);
@@ -185,7 +185,7 @@ describe("ENSIndexer: Config", () => {
         // Test invalid labelSetId
         expect(
           formatParseError(
-            makeENSIndexerPublicConfigSchema().safeParse({
+            makeEnsIndexerPublicConfigSchema().safeParse({
               ...validConfig,
               labelSet: { ...validConfig.labelSet, labelSetId: "" },
             }),
@@ -195,7 +195,7 @@ describe("ENSIndexer: Config", () => {
         // Test invalid labelSetVersion
         expect(
           formatParseError(
-            makeENSIndexerPublicConfigSchema().safeParse({
+            makeEnsIndexerPublicConfigSchema().safeParse({
               ...validConfig,
               labelSet: { ...validConfig.labelSet, labelSetVersion: "not-a-number" },
             }),

packages/ensnode-sdk/src/ensindexer/config/zod-schemas.ts

@@ -119,7 +119,7 @@ export const makeFullyPinnedLabelSetSchema = (valueLabel: string = "Label set")
 const makeNonEmptyStringSchema = (valueLabel: string = "Value") =>
   z.string().nonempty({ error: `${valueLabel} must be a non-empty string.` });
 
-export const makeENSIndexerVersionInfoSchema = (valueLabel: string = "Value") =>
+export const makeEnsIndexerVersionInfoSchema = (valueLabel: string = "Value") =>
   z
     .strictObject(
       {
@@ -137,6 +137,11 @@ export const makeENSIndexerVersionInfoSchema = (valueLabel: string = "Value") =>
     )
     .check(invariant_ensDbVersionIsSameAsEnsIndexerVersion);
 
+/**
+ * @deprecated Use {@link makeEnsIndexerVersionInfoSchema} instead.
+ */
+export const makeENSIndexerVersionInfoSchema = makeEnsIndexerVersionInfoSchema;
+
 // Invariant: If config.isSubgraphCompatible, the config must pass isSubgraphCompatible(config)
 export function invariant_isSubgraphCompatibleRequirements(
   ctx: ZodCheckFnInput<