Skip to content

Commit 1ff960e

Browse files
committed
Apply AI PR feedback
1 parent 4684fb4 commit 1ff960e

4 files changed

Lines changed: 11 additions & 21 deletions

File tree

apps/ensindexer/src/lib/ensdb-writer-worker/ensdb-writer-worker.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import type { EnsDbWriter } from "@ensnode/ensdb-sdk";
55
import {
66
buildCrossChainIndexingStatusSnapshotOmnichain,
77
buildIndexingMetadataContextInitialized,
8-
type CrossChainIndexingStatusSnapshot,
9-
type EnsIndexerPublicConfig,
108
type IndexingMetadataContext,
119
IndexingMetadataContextStatusCodes,
1210
} from "@ensnode/ensnode-sdk";
@@ -54,24 +52,18 @@ export class EnsDbWriterWorker {
5452
/**
5553
* Run the ENSDb Writer Worker
5654
*
57-
* The worker performs the following tasks:
58-
* 1) A single attempt to upsert ENSDb version into ENSDb.
59-
* 2) A single attempt to upsert serialized representation of
60-
* {@link EnsIndexerPublicConfig} into ENSDb.
61-
* 3) A recurring attempt to upsert serialized representation of
62-
* {@link CrossChainIndexingStatusSnapshot} into ENSDb.
55+
* The worker performs a recurring upsert of
56+
* the {@link IndexingMetadataContext} record into ENSDb.
6357
*
64-
* @throws Error if the worker is already running, or
65-
* if the in-memory ENSIndexer Public Config could not be fetched, or
66-
* if the in-memory ENSIndexer Public Config is incompatible with the stored config in ENSDb.
58+
* @throws Error if the worker is already running.
6759
*/
6860
public async run(): Promise<void> {
6961
// Do not allow multiple concurrent runs of the worker
7062
if (this.isRunning) {
7163
throw new Error("EnsDbWriterWorker is already running");
7264
}
7365

74-
// Task 1: recurring upsert of Indexing Metadata Context into ENSDb.
66+
// Recurring upsert of Indexing Metadata Context into ENSDb.
7567
this.indexingStatusInterval = setInterval(
7668
() => this.upsertIndexingMetadataContext(),
7769
secondsToMilliseconds(INDEXING_STATUS_RECORD_UPDATE_INTERVAL),

packages/ensnode-sdk/src/ensnode/metadata/deserialize/indexing-metadata-context.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
/**
2121
* Builds an unvalidated {@link IndexingMetadataContextInitialized} object.
2222
*/
23-
function buildUnvalidatedIndexingMetadataContextInitializedSchema(
23+
function buildUnvalidatedIndexingMetadataContextInitialized(
2424
serializedIndexingMetadataContext: SerializedIndexingMetadataContextInitialized,
2525
): Unvalidated<IndexingMetadataContextInitialized> {
2626
return {
@@ -37,19 +37,16 @@ function buildUnvalidatedIndexingMetadataContextInitializedSchema(
3737
* validated with {@link makeIndexingMetadataContextSchema}.
3838
*
3939
* @param serializedIndexingMetadataContext - The serialized indexing metadata context to build from.
40-
* @return An unvalidated {@link IndexingMetadataContextInitialized} object.
4140
*/
42-
function buildUnvalidatedIndexingMetadataContextSchema(
41+
function buildUnvalidatedIndexingMetadataContext(
4342
serializedIndexingMetadataContext: SerializedIndexingMetadataContext,
4443
): Unvalidated<IndexingMetadataContext> {
4544
switch (serializedIndexingMetadataContext.statusCode) {
4645
case IndexingMetadataContextStatusCodes.Uninitialized:
4746
return serializedIndexingMetadataContext;
4847

4948
case IndexingMetadataContextStatusCodes.Initialized:
50-
return buildUnvalidatedIndexingMetadataContextInitializedSchema(
51-
serializedIndexingMetadataContext,
52-
);
49+
return buildUnvalidatedIndexingMetadataContextInitialized(serializedIndexingMetadataContext);
5350
}
5451
}
5552

@@ -63,7 +60,7 @@ export function deserializeIndexingMetadataContext(
6360
const label = valueLabel ?? "IndexingMetadataContext";
6461

6562
const parsed = makeSerializedIndexingMetadataContextSchema(label)
66-
.transform(buildUnvalidatedIndexingMetadataContextSchema)
63+
.transform(buildUnvalidatedIndexingMetadataContext)
6764
.pipe(makeIndexingMetadataContextSchema(label))
6865
.safeParse(serializedIndexingMetadataContext);
6966

packages/ensnode-sdk/src/ensnode/metadata/indexing-metadata-context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { validateIndexingMetadataContextInitialized } from "./validate/indexing-
77
*/
88
export const IndexingMetadataContextStatusCodes = {
99
/**
10-
* Represents that the no indexing metadata context has been initialized
10+
* Represents that no indexing metadata context has been initialized
1111
* for the ENSIndexer Schema Name in the ENSNode Metadata table in ENSDb.
1212
*/
1313
Uninitialized: "uninitialized",

packages/ensnode-sdk/src/ensnode/metadata/validate/indexing-metadata-context.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ import { makeIndexingMetadataContextInitializedSchema } from "../zod-schemas/ind
99
*/
1010
export function validateIndexingMetadataContextInitialized(
1111
maybeIndexingMetadataContext: Unvalidated<IndexingMetadataContextInitialized>,
12+
valueLabel?: string,
1213
): IndexingMetadataContextInitialized {
13-
const result = makeIndexingMetadataContextInitializedSchema().safeParse(
14+
const result = makeIndexingMetadataContextInitializedSchema(valueLabel).safeParse(
1415
maybeIndexingMetadataContext,
1516
);
1617

0 commit comments

Comments
 (0)