Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| bundle: true, | ||
| splitting: false, | ||
| sourcemap: true, | ||
| // dts: true, |
There was a problem hiding this comment.
@tk-o enabling this causes ponder-schema not to build with tsup. It looks like ponder needs to export Relations and Table from Drizzle that we can then re-export, perhaps, I'm not sure.
There was a problem hiding this comment.
I think it's an issue coming from drizzle-orm. We might need to skip declaration type generation for ponder-schema package until the underlying problem is fixed. Possibly related:
There was a problem hiding this comment.
@tk-o perhaps we can wait a few days for this to be merged in and see if it resolves our issue, or figure out a workaround that's not pretty. Third option would be to merge this as is now, and then come back to enable this option once the PR above is merged.
There was a problem hiding this comment.
Drizzle is a downstream dependency, we don't import it directly. I assume it's gonna take some weeks before Ponder team decides to update Drizzle dependency, and we get the updateded ponder package to use in our repo.
Co-authored-by: Jamie Barton <jamie@notrab.dev>
notrab
force-pushed
the
build-packages
branch
from
27bd464 to
95bd0e9
Compare
|
@tk-o I'm happy for us to merge this now, then it should close the original issue. I can then aim towards an official release using changesets by adding the necessary files. |
2 participants
Closes #193