Switch from redmine_base_deface plugin to redmine_plugin_kit gem#55
Open
alexandermeindl wants to merge 1 commit into
Open
Switch from redmine_base_deface plugin to redmine_plugin_kit gem#55alexandermeindl wants to merge 1 commit into
alexandermeindl wants to merge 1 commit into
Conversation
…ropin replacement for deface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get more compatibility with other plugins, it would be great to use redmine_plugin_kit Gem instead of redmine_base_deface plugin. This would also be easier for users, because they do not have to manually install another plugin.
redmine_plugin_kit just provides the required deface gem and path for overwrites (as redmine_base_deface). All plugins which uses redmine_plugin_kit will get the same version of deface from this Gem.
I do not use redmine_base_deface plugin, because users have to make one more step (which can cause more support).
It would be great, if this patch would be merged.
PS: another reason to switch to the Gem is Rails 6.1 / Zeitwerk support. Latest Redmine patches do not work with deface, if Rails.application.paths is not added with application start.