test: add unit tests for extractJsonFromModelOutput and removeThinkTags#321
Open
nuthalapativarun wants to merge 1 commit into
Open
test: add unit tests for extractJsonFromModelOutput and removeThinkTags#321nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
Add 14 tests covering all JSON extraction paths in messages/utils.ts: plain JSON, code block (generic and json-tagged), Llama tool_call and python_tag formats, error cases (invalid JSON, empty string), and nested objects. Also covers removeThinkTags including stray closing tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extractJsonFromModelOutputandremoveThinkTagsinchrome-extension/src/background/agent/messages/utils.tshave zero test coverage despite handling several branching code paths (plain JSON, markdown code blocks, Llama tool call / python tag formats, stray closing think tags).Solution
Add
src/background/agent/__tests__/utils.test.tswith 14 tests following the same Vitest pattern used by the existing guardrails test suite.Coverage added:
removeThinkTags: well-formed tags, multiline, stray closing tag, no tags, tags-onlyextractJsonFromModelOutput: plain JSON, generic code block,json-tagged code block, Llama<|tool_call_start_id|>with and without end tag, Llama<|python_tag|>, invalid JSON, empty string, nested objectsChanges
chrome-extension/src/background/agent/__tests__/utils.test.ts— new test file, 14 testsTesting
pnpm -F chrome-extension testpasses — 28 tests total (14 existing + 14 new)pnpm -F @extension/i18n type-checkpasses