Skip to content

Strengthen preview/stable target-list test by asserting non-empty preview results#336

Draft
Ellerbach with Copilot wants to merge 5 commits into
mainfrom
copilot/sub-pr-335
Draft

Strengthen preview/stable target-list test by asserting non-empty preview results#336
Ellerbach with Copilot wants to merge 5 commits into
mainfrom
copilot/sub-pr-335

Conversation

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

This stacked PR follows up on review feedback from #335: the preview package list in FirmwarePackage_ListReferenceTargets was only checked for non-null, which could let the preview-vs-stable invariant silently pass when preview results are empty.

  • Test correctness hardening

    • Added a non-empty assertion for the preview package list in nanoFirmwareFlasher.Tests/FirmwarePackageTests.cs.
    • This aligns the preview list checks with the existing pattern used for stable/platform-filtered lists.
  • Behavioral impact

    • The test now fails fast when preview retrieval returns an empty set, instead of skipping the core preview-vs-stable containment check via a no-op loop.
Assert.IsNotNull(preview);
Assert.AreNotEqual(0, preview.Count);

Copilot AI mentioned this pull request Apr 21, 2026
14 tasks
Base automatically changed from fix-tests to main April 21, 2026 12:45

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.cloudsmith.io
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 38871 --endpoint 127.0.0.1:038871 --role client --parentprocessid 4414 --telemetryoptedin false (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 42043 --endpoint 127.0.0.1:042043 --role client --parentprocessid 4502 --telemetryoptedin false (dns block)
  • https://api.github.com/repos/nanoframework/nanoFirmwareFlasher/releases/latest
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 38871 --endpoint 127.0.0.1:038871 --role client --parentprocessid 4414 --telemetryoptedin false (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on fixing failing test in PR #335 Strengthen preview/stable target-list test by asserting non-empty preview results Apr 21, 2026
Copilot AI requested a review from Ellerbach April 21, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants