Skip to content

Align platform-filtered firmware target test verbosity#337

Draft
Ellerbach with Copilot wants to merge 5 commits into
mainfrom
copilot/sub-pr-335-again
Draft

Align platform-filtered firmware target test verbosity#337
Ellerbach with Copilot wants to merge 5 commits into
mainfrom
copilot/sub-pr-335-again

Conversation

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

This stacked PR follows up on review feedback in #335: FirmwarePackage_ListReferenceTargets used mixed verbosity levels across platform-filtered stable target fetches. The inconsistency produced unnecessary diagnostic output for ESP32 and made the test setup uneven.

  • Problem addressed

    • Standardized verbosity in the four platform-filtered stable target list calls inside FirmwarePackageTests.
  • Change made

    • Switched the ESP32 stable fetch from VerbosityLevel.Diagnostic to VerbosityLevel.Quiet to match TI, STM32, and EFM32 paths.
  • Resulting test intent

    • All platform-filtered stable fetches now run with equivalent output behavior, keeping test logs consistent and quieter.
List<CloudSmithPackageDetail> stableEsp32 = FirmwarePackage.GetTargetList(
    false,
    false,
    SupportedPlatform.esp32,
    VerbosityLevel.Quiet);

Copilot AI mentioned this pull request Apr 21, 2026
14 tasks
Base automatically changed from fix-tests to main April 21, 2026 12:45

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.cloudsmith.io
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 33327 --endpoint 127.0.0.1:033327 --role client --parentprocessid 4394 --telemetryoptedin false (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 45225 --endpoint 127.0.0.1:045225 --role client --parentprocessid 4520 --telemetryoptedin false (dns block)
  • https://api.github.com/repos/nanoframework/nanoFirmwareFlasher/releases/latest
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/nanoFirmwareFlasher.Tests.deps.json /home/REDACTED/work/nanoFirmwareFlasher/nanoFirmwareFlasher/nanoFirmwareFlasher.Tests/bin/Debug/net8.0/testhost.dll --port 33327 --endpoint 127.0.0.1:033327 --role client --parentprocessid 4394 --telemetryoptedin false (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback from review to resolve failing test issue Align platform-filtered firmware target test verbosity Apr 21, 2026
Copilot AI requested a review from Ellerbach April 21, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants