Skip to content

Commit 4e89e49

Browse files
committed
PR review comments. Clarifications
1 parent 6388958 commit 4e89e49

2 files changed

Lines changed: 35 additions & 9 deletions

File tree

ManagedDrivers/Ili9488/Ili9488.cs

Lines changed: 34 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,40 @@ private enum ILI9488_CMD
6161

6262
private enum ILI9488_Orientation
6363
{
64-
MADCTL_MH = 0x04, // sets the Horizontal Refresh, 0=Left-Right and 1=Right-Left
65-
MADCTL_ML = 0x10, // sets the Vertical Refresh, 0=Top-Bottom and 1=Bottom-Top
66-
MADCTL_MV = 0x20, // sets the Row/Column Swap, 0=Normal and 1=Swapped
67-
MADCTL_MX = 0x40, // sets the Column Order, 0=Left-Right and 1=Right-Left
68-
MADCTL_MY = 0x80, // sets the Row Order, 0=Top-Bottom and 1=Bottom-Top
64+
/// <summary>
65+
/// Sets the Horizontal Refresh, 0=Left-Right and 1=Right-Left
66+
/// </summary>
67+
MADCTL_MH = 0x04,
6968

70-
MADCTL_BGR = 0x08, // Blue-Green-Red pixel order
71-
MADCTL_RGB = 0x00 // Red-Green-Blue pixel order
69+
/// <summary>
70+
/// Sets the Vertical Refresh, 0=Top-Bottom and 1=Bottom-Top
71+
/// </summary>
72+
MADCTL_ML = 0x10,
73+
74+
/// <summary>
75+
/// Sets the Row/Column Swap, 0=Normal and 1=Swapped
76+
/// </summary>
77+
MADCTL_MV = 0x20,
78+
79+
/// <summary>
80+
/// Sets the Column Order, 0=Left-Right and 1=Right-Left
81+
/// </summary>
82+
MADCTL_MX = 0x40,
83+
84+
/// <summary>
85+
/// Sets the Row Order, 0=Top-Bottom and 1=Bottom-Top
86+
/// </summary>
87+
MADCTL_MY = 0x80,
88+
89+
/// <summary>
90+
/// Blue-Green-Red pixel order
91+
/// </summary>
92+
MADCTL_BGR = 0x08,
93+
94+
/// <summary>
95+
/// Red-Green-Blue pixel order
96+
/// </summary>
97+
MADCTL_RGB = 0x00
7298
};
7399

74100
/// <summary>
@@ -100,7 +126,7 @@ public static GraphicDriver GraphicDriver
100126
(byte)GraphicDriverCommandType.Command, 3, (byte)ILI9488_CMD.Power_Control_1, 0x17, 0x15,
101127
(byte)GraphicDriverCommandType.Command, 2, (byte)ILI9488_CMD.Power_Control_2, 0x41,
102128
(byte)GraphicDriverCommandType.Command, 4, (byte)ILI9488_CMD.VCOM_Control_1, 0x00, 0x12, 0x80,
103-
(byte)GraphicDriverCommandType.Command, 2, (byte)ILI9488_CMD.Pixel_Format_Set, 0x66, // 18 bit SPI
129+
(byte)GraphicDriverCommandType.Command, 2, (byte)ILI9488_CMD.Pixel_Format_Set, 0x66, // 18-bit. Native generic driver supports 18-bit transfers via conversion to RGB666
104130
(byte)GraphicDriverCommandType.Command, 16, (byte)ILI9488_CMD.Positive_Gamma_Correction, 0x00, 0x03, 0x09, 0x08, 0x16, 0x0A, 0x3F, 0x78, 0x4C, 0x09, 0x0A, 0x08, 0x16, 0x1A, 0x0F,
105131
(byte)GraphicDriverCommandType.Command, 16, (byte)ILI9488_CMD.Negative_Gamma_Correction, 0x00, 0x16, 0x19, 0x03, 0x0F, 0x05, 0x32, 0x45, 0x46, 0x04, 0x0E, 0x0D, 0x35, 0x37, 0x0F,
106132
(byte)GraphicDriverCommandType.Command, 2, (byte)ILI9488_CMD.Interface_Signal_Control, 0x80,

ManagedDrivers/Ili9488/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// associated with an assembly.
77
[assembly: AssemblyTitle("nanoFramework.Graphics.Ili9488")]
88
[assembly: AssemblyCompany("nanoFramework Contributors")]
9-
[assembly: AssemblyProduct("nanoFramework.System.Text")]
9+
[assembly: AssemblyProduct("nanoFramework.Graphics.Ili9488")]
1010
[assembly: AssemblyCopyright("Copyright © nanoFramework Contributors 2026")]
1111

1212
// Setting ComVisible to false makes the types in this assembly not visible

0 commit comments

Comments
 (0)