Moving to C23 and C++23

- Update toolchain and build config files.
- Migrate code to use new versions and keywords.

Author: josesimoes

.github/copilot-instructions.md

@@ -103,8 +103,8 @@ There is no standalone test suite or test runner in this repository. Testing is
 
 ### Language Standards
 
-- **C++20** (`stdcpp20`) for C++ files (`.cpp`).
-- **C17** (`stdc17`) for C files (`.c`).
+- **C++23** (`stdcpp23`) for C++ files (`.cpp`).
+- **C23** (`stdc23`) for C files (`.c`).
 - HAL-level code tends to be C; CLR, PAL, and device API code is C++.
 
 ### Formatting

CMake/toolchain.arm-none-eabi.cmake

@@ -50,10 +50,5 @@ set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
 set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)
 
 # set required C and C++ standard for ALL targets
-set(CMAKE_C_STANDARD 17 CACHE INTERNAL "C standard for all targets")
-set(CMAKE_CXX_STANDARD 17 CACHE INTERNAL "C++ standard for all targets")
-
-# set all C and C++ extensions to be OFF on ALL targets
-# this forces the use of -std=c17 and -std=c++17 instead of -std=gnu17 and -std=gnu++17
-set(CMAKE_C_EXTENSIONS OFF CACHE INTERNAL "C compiler extensions OFF")
-set(CMAKE_CXX_EXTENSIONS OFF CACHE INTERNAL "C++ compiler extensions OFF")
+set(CMAKE_C_STANDARD 23 CACHE INTERNAL "C standard for all targets")
+set(CMAKE_CXX_STANDARD 23 CACHE INTERNAL "C++ standard for all targets")

nf.props

@@ -25,8 +25,8 @@
     <ClCompile>
       <PreprocessorDefinitions>VIRTUAL_DEVICE;_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING;VERSION_MAJOR=$(NBGV_VersionMajor);VERSION_MINOR=$(NBGV_VersionMinor);VERSION_BUILD=$(NBGV_BuildNumber);VERSION_REVISION=$(TARGET_BUILD_COUNTER);PLATFORMNAMESTRING="WINDOWS";</PreprocessorDefinitions>
       <AdditionalIncludeDirectories>..\..\targets\win32\Include;..\..\targets\netcore\nanoFramework.nanoCLR;..\..\..\targets\netcore\nanoFramework.nanoCLR;..\..\..\..\targets\netcore\nanoFramework.nanoCLR;..\CLR\Include;..\..\CLR\Include;..\CorLib;..\HAL\Include;..\..\src\HAL\Include;..\..\..\src\HAL\Include;..\..\..\..\src\HAL\Include;..\PAL\Include;</AdditionalIncludeDirectories>
-      <LanguageStandard>stdcpp20</LanguageStandard>
-      <LanguageStandard_C>stdc17</LanguageStandard_C>
+      <LanguageStandard>stdcpp23</LanguageStandard>
+      <LanguageStandard_C>stdc23</LanguageStandard_C>
     </ClCompile>
   </ItemDefinitionGroup>
 

src/CLR/Include/nanoCLR_Headers.h

@@ -16,16 +16,4 @@
 #include <nanoWeak.h>
 #include <nanoPackStruct.h>
 
-// Constants for configuration options
-
-// Generic 'FALSE' preprocessor boolean constant
-#if !defined(FALSE)
-#define FALSE 0
-#endif
-
-// Generic 'TRUE' preprocessor boolean constant
-#if !defined(TRUE)
-#define TRUE 1
-#endif
-
 #endif // NANOCLR_HEADERS_H

src/DeviceInterfaces/Network/Enc28j60/enc28j60_lwip.cpp

@@ -928,7 +928,7 @@ bool enc28j60_lwip_setup_device(struct netif *pNetIF)
         ENC28J60_ECON1,
         (uint8_t)(1 << ENC28J60_ECON1_RXEN_BIT));
 
-    return TRUE;
+    return true;
 }
 
 void enc28j60_lwip_destroy_device()

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Security_CertificateManager.cpp

@@ -53,7 +53,7 @@ HRESULT Library_sys_net_native_System_Net_Security_CertificateManager::
                 0,
                 certificateSize,
                 0,
-                true) != TRUE)
+                true) != true)
         {
             NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
         }
@@ -70,7 +70,7 @@ HRESULT Library_sys_net_native_System_Net_Security_CertificateManager::
     }
 
     // reach here, we should be OK
-    stack.SetResult_Boolean(TRUE);
+    stack.SetResult_Boolean(true);
 
     NANOCLR_CLEANUP();
 

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Security_SslNative.cpp

@@ -223,7 +223,7 @@ HRESULT Library_sys_net_native_System_Net_Security_SslNative::ExitSecureContext_
 
     CLR_INT32 sslContext = stack.Arg0().NumericByRef().s4;
 
-    int result = SSL_ExitContext(sslContext) == TRUE ? 0 : -1;
+    int result = SSL_ExitContext(sslContext) == true ? 0 : -1;
 
     stack.SetResult_I4(result);
 

src/HAL/nanoHAL_SystemInformation.cpp

@@ -44,7 +44,7 @@ bool GetHalSystemInfo(HalSystemInfo &systemInfo)
         (char *)&systemInfo.m_OemSerialNumbers.system_serial_number,
         sizeof(systemInfo.m_OemSerialNumbers.system_serial_number));
 
-    return TRUE;
+    return true;
 #endif
 }
 
@@ -62,7 +62,7 @@ bool Target_GetReleaseInfo(NFReleaseInfo &releaseInfo)
         hal_strlen_s(TARGETNAMESTRING),
         PLATFORMNAMESTRING,
         hal_strlen_s(PLATFORMNAMESTRING));
-    return TRUE; // alternatively, return false if you didn't initialize the releaseInfo structure.
+    return true; // alternatively, return false if you didn't initialize the releaseInfo structure.
 }
 
 bool DebuggerIsConnected()

src/PAL/AsyncProcCall/AsyncCompletions.cpp

@@ -242,7 +242,7 @@ void HAL_COMPLETION::Uninitialize()
 
     GLOBAL_LOCK();
 
-    while (TRUE)
+    while (true)
     {
         ptr = (HAL_COMPLETION *)g_HAL_Completion_List.ExtractFirstNode();
 

src/PAL/AsyncProcCall/AsyncContinuations.cpp

@@ -94,7 +94,7 @@ void HAL_CONTINUATION::Uninitialize()
 
     HAL_CONTINUATION *ptr;
 
-    while (TRUE)
+    while (true)
     {
         ptr = (HAL_CONTINUATION *)g_HAL_Continuation_List.ExtractFirstNode();