docs: remove incorrect 400 response from DELETE endpoint (#248)

- Remove invalid Bad Request response code from DELETE OpenAPI spec
- Refactor squad number lookup test to use stream filter vs hardcoded index

Author: nanotaboada

src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/PlayersController.java

@@ -245,7 +245,6 @@ public ResponseEntity<Void> put(@PathVariable Long id, @RequestBody @Valid Playe
     @Operation(summary = "Deletes a player by ID")
     @ApiResponses(value = {
             @ApiResponse(responseCode = "204", description = "No Content", content = @Content),
-            @ApiResponse(responseCode = "400", description = "Bad Request", content = @Content),
             @ApiResponse(responseCode = "404", description = "Not Found", content = @Content)
     })
     public ResponseEntity<Void> delete(@PathVariable Long id) {

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/PlayersControllerTests.java

@@ -318,7 +318,10 @@ void searchByLeague_noMatches_returnsOkWithEmptyList()
     void searchBySquadNumber_playerExists_returnsOkWithPlayer()
             throws Exception {
         // Arrange
-        PlayerDTO playerDTO = PlayerDTOFakes.createAll().get(9); // Messi is at index 9
+        PlayerDTO playerDTO = PlayerDTOFakes.createAll().stream()
+                .filter(player -> player.getSquadNumber() == 10)
+                .findFirst()
+                .orElseThrow();
         Mockito
                 .when(playersServiceMock.searchBySquadNumber(10))
                 .thenReturn(playerDTO);

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/PlayersServiceTests.java

@@ -18,14 +18,14 @@
 import org.mockito.Mockito;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.modelmapper.ModelMapper;
+import org.springframework.dao.DataIntegrityViolationException;
 
 import ar.com.nanotaboada.java.samples.spring.boot.models.Player;
 import ar.com.nanotaboada.java.samples.spring.boot.models.PlayerDTO;
 import ar.com.nanotaboada.java.samples.spring.boot.repositories.PlayersRepository;
 import ar.com.nanotaboada.java.samples.spring.boot.services.PlayersService;
 import ar.com.nanotaboada.java.samples.spring.boot.test.PlayerDTOFakes;
 import ar.com.nanotaboada.java.samples.spring.boot.test.PlayerFakes;
-import org.springframework.dao.DataIntegrityViolationException;
 
 @DisplayName("CRUD Operations on Service")
 @ExtendWith(MockitoExtension.class)
@@ -87,7 +87,10 @@ void create_noConflict_returnsPlayerDTO() {
     void create_squadNumberExists_returnsNull() {
         // Arrange
         PlayerDTO playerDTO = PlayerDTOFakes.createOneValid();
-        Player existingPlayer = PlayerFakes.createAll().get(4); // Squad number 5 already exists
+        Player existingPlayer = PlayerFakes.createAll().stream()
+                .filter(player -> player.getSquadNumber() == 10)
+                .findFirst()
+                .orElseThrow();
         Mockito
                 .when(playersRepositoryMock.findBySquadNumber(playerDTO.getSquadNumber()))
                 .thenReturn(Optional.of(existingPlayer));
@@ -264,8 +267,14 @@ void searchByLeague_noMatches_returnsEmptyList() {
     @Test
     void searchBySquadNumber_playerExists_returnsPlayerDTO() {
         // Arrange
-        Player player = PlayerFakes.createAll().get(9); // Messi is at index 9
-        PlayerDTO playerDTO = PlayerDTOFakes.createAll().get(9);
+        Player player = PlayerFakes.createAll().stream()
+                .filter(p -> p.getSquadNumber() == 10)
+                .findFirst()
+                .orElseThrow();
+        PlayerDTO playerDTO = PlayerDTOFakes.createAll().stream()
+                .filter(p -> p.getSquadNumber() == 10)
+                .findFirst()
+                .orElseThrow();
         Mockito
                 .when(playersRepositoryMock.findBySquadNumber(10))
                 .thenReturn(Optional.of(player));