refactor(tests): address code review findings

Author: nanotaboada

src/main/java/ar/com/nanotaboada/java/samples/spring/boot/repositories/PlayersRepository.java

@@ -4,8 +4,6 @@
 import java.util.Optional;
 
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Query;
-import org.springframework.data.repository.query.Param;
 import org.springframework.stereotype.Repository;
 
 import ar.com.nanotaboada.java.samples.spring.boot.models.Player;
@@ -65,6 +63,5 @@ public interface PlayersRepository extends JpaRepository<Player, Long> {
      * @return a list of players whose league name contains the search term (empty
      * list if none found)
      */
-    @Query("SELECT p FROM Player p WHERE LOWER(p.league) LIKE LOWER(CONCAT('%', :league, '%'))")
-    List<Player> findByLeagueContainingIgnoreCase(@Param("league") String league);
+    List<Player> findByLeagueContainingIgnoreCase(String league);
 }

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/PlayersControllerTests.java

@@ -32,7 +32,6 @@
 
 import ar.com.nanotaboada.java.samples.spring.boot.controllers.PlayersController;
 import ar.com.nanotaboada.java.samples.spring.boot.models.PlayerDTO;
-import ar.com.nanotaboada.java.samples.spring.boot.repositories.PlayersRepository;
 import ar.com.nanotaboada.java.samples.spring.boot.services.PlayersService;
 import ar.com.nanotaboada.java.samples.spring.boot.test.PlayerDTOFakes;
 
@@ -50,9 +49,6 @@ class PlayersControllerTests {
     @MockitoBean
     private PlayersService playersServiceMock;
 
-    @MockitoBean
-    private PlayersRepository playersRepositoryMock;
-
     @Autowired
     private ObjectMapper objectMapper;
 
@@ -257,7 +253,7 @@ void givenPlayerExists_whenGetBySquadNumber_thenReturnsOk()
         // Given
         Integer squadNumber = 10;
         PlayerDTO expected = PlayerDTOFakes.createAll().stream()
-                .filter(player -> player.getSquadNumber() == squadNumber)
+                .filter(player -> squadNumber.equals(player.getSquadNumber()))
                 .findFirst()
                 .orElseThrow();
         Mockito

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/repositories/PlayersRepositoryTests.java

@@ -58,7 +58,7 @@ void givenPlayerDoesNotExist_whenFindById_thenReturnsEmpty() {
     }
 
     /**
-     * Given players exist in a specific league
+     * Given players exist in a specific league (pre-seeded from dml.sql)
      * When searching by league name
      * Then a list of matching players is returned
      */
@@ -89,22 +89,20 @@ void givenNoPlayersExist_whenFindByLeague_thenReturnsEmptyList() {
     }
 
     /**
-     * Given a player with a specific squad number exists in the database
+     * Given a player with a specific squad number exists (pre-seeded from dml.sql)
      * When querying by that squad number
      * Then the player record is returned
      */
     @Test
     void givenPlayerExists_whenFindBySquadNumber_thenReturnsPlayer() {
         // Given
-        Player expected = PlayerFakes.createAll().stream()
-                .filter(p -> p.getId().equals(10L))
-                .findFirst()
-                .orElseThrow();
+        Integer expectedSquadNumber = 10; // Messi's squad number from pre-seeded data
         // When
-        Optional<Player> actual = repository.findBySquadNumber(expected.getSquadNumber());
+        Optional<Player> actual = repository.findBySquadNumber(expectedSquadNumber);
         // Then
         then(actual).isPresent();
-        then(actual.get()).usingRecursiveComparison().isEqualTo(expected);
+        then(actual.get().getSquadNumber()).isEqualTo(expectedSquadNumber);
+        then(actual.get().getLastName()).isEqualTo("Messi");
     }
 
     /**

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/PlayersServiceTests.java

@@ -89,7 +89,7 @@ void givenPlayerAlreadyExists_whenCreate_thenReturnsNull() {
         PlayerDTO dto = PlayerDTOFakes.createOneValid();
         Integer expectedSquadNumber = 10;
         Player existingPlayer = PlayerFakes.createAll().stream()
-                .filter(player -> player.getSquadNumber() == expectedSquadNumber)
+                .filter(player -> expectedSquadNumber.equals(player.getSquadNumber()))
                 .findFirst()
                 .orElseThrow();
         Mockito
@@ -160,6 +160,7 @@ void givenAllPlayersExist_whenRetrieveAll_thenReturns26Players() {
         // Then
         verify(playersRepositoryMock, times(1)).findAll();
         then(actual).hasSize(26);
+        then(actual).usingRecursiveComparison().isEqualTo(dtos);
     }
 
     /**
@@ -216,11 +217,11 @@ void givenPlayerExists_whenRetrieveBySquadNumber_thenReturnsPlayerDTO() {
         // Given
         Integer squadNumber = 10;
         Player entity = PlayerFakes.createAll().stream()
-                .filter(player -> player.getSquadNumber() == squadNumber)
+                .filter(player -> squadNumber.equals(player.getSquadNumber()))
                 .findFirst()
                 .orElseThrow();
         PlayerDTO expected = PlayerDTOFakes.createAll().stream()
-                .filter(player -> player.getSquadNumber() == squadNumber)
+                .filter(player -> squadNumber.equals(player.getSquadNumber()))
                 .findFirst()
                 .orElseThrow();
         Mockito