Skip to content

Commit 5ad2f8b

Browse files
committed
docs: remove incorrect 400 response from DELETE endpoint (#248)
- Remove invalid Bad Request response code from DELETE OpenAPI spec - Refactor squad number lookup test to use stream filter vs hardcoded index
1 parent 4d1c080 commit 5ad2f8b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/PlayersController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ public ResponseEntity<Void> put(@PathVariable Long id, @RequestBody @Valid Playe
245245
@Operation(summary = "Deletes a player by ID")
246246
@ApiResponses(value = {
247247
@ApiResponse(responseCode = "204", description = "No Content", content = @Content),
248-
@ApiResponse(responseCode = "400", description = "Bad Request", content = @Content),
249248
@ApiResponse(responseCode = "404", description = "Not Found", content = @Content)
250249
})
251250
public ResponseEntity<Void> delete(@PathVariable Long id) {

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/PlayersControllerTests.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,10 @@ void searchByLeague_noMatches_returnsOkWithEmptyList()
318318
void searchBySquadNumber_playerExists_returnsOkWithPlayer()
319319
throws Exception {
320320
// Arrange
321-
PlayerDTO playerDTO = PlayerDTOFakes.createAll().get(9); // Messi is at index 9
321+
PlayerDTO playerDTO = PlayerDTOFakes.createAll().stream()
322+
.filter(player -> player.getSquadNumber() == 10)
323+
.findFirst()
324+
.orElseThrow();
322325
Mockito
323326
.when(playersServiceMock.searchBySquadNumber(10))
324327
.thenReturn(playerDTO);

0 commit comments

Comments
 (0)