Skip to content

Commit 920e843

Browse files
nanotaboadaclaude
andcommitted
refactor(service): use delete(entity) instead of deleteById in deleteBySquadNumber (#268)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 72a925d commit 920e843

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/ar/com/nanotaboada/java/samples/spring/boot/services/PlayersService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ public boolean deleteBySquadNumber(Integer squadNumber) {
243243

244244
return playersRepository.findBySquadNumber(squadNumber)
245245
.map(existing -> {
246-
playersRepository.deleteById(existing.getId());
246+
playersRepository.delete(existing);
247247
log.info("Player deleted successfully - Squad Number: {}", squadNumber);
248248
return true;
249249
})

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/PlayersServiceTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ void givenPlayerExists_whenDelete_thenReturnsTrue() {
415415
boolean actual = playersService.deleteBySquadNumber(squadNumber);
416416
// Then
417417
verify(playersRepositoryMock, times(1)).findBySquadNumber(squadNumber);
418-
verify(playersRepositoryMock, times(1)).deleteById(entity.getId());
418+
verify(playersRepositoryMock, times(1)).delete(entity);
419419
then(actual).isTrue();
420420
}
421421

0 commit comments

Comments
 (0)