Commit ef72cf6
committed
feat(domain)!: refactor from Books to Players domain model (#248)
Replace Book entity with Player entity representing Argentina 2022 FIFA World Cup squad.
Domain Model Changes:
- Entity: Book (ISBN-based) → Player (ID-based with squad numbers)
- DTOs: BookDTO → PlayerDTO with comprehensive validation
- Natural key: ISBN → Squad number (jersey numbers like Messi #10)
- Date converter: UnixTimestampConverter (INTEGER) → IsoDateConverter (ISO-8601 TEXT)
Database Migration:
- Production: books-sqlite3.db → players-sqlite3.db (26 players pre-seeded)
- Test: H2 in-memory → SQLite in-memory (maintains compatibility)
- Schema: ddl.sql, dml.sql for test data initialization
Architecture (all layers refactored):
- Controllers: BooksController → PlayersController (comprehensive JavaDoc)
- Services: BooksService → PlayersService (caching strategy unchanged)
- Repositories: BooksRepository → PlayersRepository (added squad number search)
- Fakes: BookFakes/BookDTOFakes → PlayerFakes/PlayerDTOFakes
API Changes:
- /books → /players endpoints
- /books/search?description={keyword} → /players/search/league/{league}
- Added: /players/search/squadnumber/{squadNumber} endpoint
Test Improvements:
- Naming: givenMethod_whenX_thenY → method_scenario_outcome
- BDD JavaDoc: Added Given/When/Then structure to all tests
- Coverage: Excluded converters package from JaCoCo/Codecov
DevOps & Configuration:
- Docker Compose: Updated STORAGE_PATH to players-sqlite3.db
- Entrypoint script: Updated database paths for container initialization
- CodeRabbit: Updated validation rules, test naming pattern, fake factories
Documentation:
- Updated copilot-instructions.md with test naming convention
- Updated AGENTS.md and README.md with new endpoints
- Comprehensive JavaDoc on all new classes (controllers, services, models)
- Production database: 26 Argentina 2022 World Cup players
BREAKING CHANGE: Complete API contract change from /books to /players endpoints. All Book-related endpoints removed. Clients must migrate to new Player API.1 parent c4d23ff commit ef72cf6
File tree
37 files changed
+2197
-1368
lines changed- .github
- .vscode
- scripts
- src
- main
- java/ar/com/nanotaboada/java/samples/spring/boot
- controllers
- converters
- models
- repositories
- services
- resources
- test
- java/ar/com/nanotaboada/java/samples/spring/boot/test
- controllers
- repositories
- services
- resources
- storage
37 files changed
+2197
-1368
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
| 73 | + | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
92 | 93 | | |
93 | | - | |
| 94 | + | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
27 | 55 | | |
28 | 56 | | |
29 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
3 | 9 | | |
4 | 10 | | |
5 | 11 | | |
| |||
8 | 14 | | |
9 | 15 | | |
10 | 16 | | |
| 17 | + | |
11 | 18 | | |
12 | 19 | | |
13 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
| 184 | + | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
191 | 191 | | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
196 | 199 | | |
197 | 200 | | |
198 | | - | |
199 | | - | |
200 | | - | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
201 | 204 | | |
202 | 205 | | |
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
206 | 209 | | |
207 | | - | |
| 210 | + | |
208 | 211 | | |
209 | 212 | | |
210 | 213 | | |
211 | 214 | | |
| 215 | + | |
212 | 216 | | |
213 | 217 | | |
214 | 218 | | |
| |||
217 | 221 | | |
218 | 222 | | |
219 | 223 | | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
225 | 231 | | |
226 | 232 | | |
227 | 233 | | |
| |||
265 | 271 | | |
266 | 272 | | |
267 | 273 | | |
268 | | - | |
| 274 | + | |
269 | 275 | | |
270 | 276 | | |
271 | 277 | | |
| |||
275 | 281 | | |
276 | 282 | | |
277 | 283 | | |
278 | | - | |
| 284 | + | |
279 | 285 | | |
280 | 286 | | |
281 | 287 | | |
| |||
309 | 315 | | |
310 | 316 | | |
311 | 317 | | |
312 | | - | |
313 | | - | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
314 | 326 | | |
315 | | - | |
316 | | - | |
| 327 | + | |
| 328 | + | |
317 | 329 | | |
318 | | - | |
319 | | - | |
| 330 | + | |
| 331 | + | |
320 | 332 | | |
321 | 333 | | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
329 | 344 | | |
330 | 345 | | |
331 | | - | |
332 | | - | |
| 346 | + | |
| 347 | + | |
333 | 348 | | |
334 | 349 | | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
342 | 361 | | |
343 | 362 | | |
344 | | - | |
345 | | - | |
| 363 | + | |
| 364 | + | |
346 | 365 | | |
347 | 366 | | |
348 | 367 | | |
| |||
353 | 372 | | |
354 | 373 | | |
355 | 374 | | |
356 | | - | |
| 375 | + | |
357 | 376 | | |
358 | 377 | | |
359 | | - | |
360 | | - | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
0 commit comments