Skip to content

chore(ci): switch to default setup for CodeQL scanning #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanotaboada merged 3 commits into from
Apr 18, 2025

fix(ci): set workflow permissions (contents: read)

b9bde07
Select commit
Loading
Failed to load commit list.
Merged

chore(ci): switch to default setup for CodeQL scanning #179

fix(ci): set workflow permissions (contents: read)
b9bde07
Select commit
Loading
Failed to load commit list.
Codeac.io / Codeac Code Quality succeeded Apr 18, 2025 in 20s

Codeac Code Quality

This PR contains 36 errors and 54 warnings.

Annotations

Check warning on line 17 in src/main/java/ar/com/nanotaboada/java/samples/spring/boot/models/Book.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 9 lines is too similar to src/main/java/ar/com/nanotaboada/java/samples/spring/boot/models/BookDTO.java:9

Check warning on line 18 in src/main/java/ar/com/nanotaboada/java/samples/spring/boot/models/BookDTO.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 9 lines is too similar to src/main/java/ar/com/nanotaboada/java/samples/spring/boot/models/Book.java:8

Check warning on line 151 in src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/BooksController.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/BooksController.java:121

Check warning on line 202 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 13 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:56

Check warning on line 128 in src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/BooksController.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/main/java/ar/com/nanotaboada/java/samples/spring/boot/controllers/BooksController.java:144

Check warning on line 69 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 13 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:189

Check failure on line 21 in .mvn/wrapper/MavenWrapperDownloader.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

NoPackage 

All classes, interfaces, enums and annotations must belong to a named package

Check warning on line 213 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:68

Check failure on line 73 in .mvn/wrapper/MavenWrapperDownloader.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

EmptyCatchBlock 

Avoid empty catch blocks

Check failure on line 94 in .mvn/wrapper/MavenWrapperDownloader.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

AvoidCatchingThrowable 

A catch statement should never catch throwable since it includes errors.

Check warning on line 80 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:201

Check warning on line 227 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 15 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:99

Check warning on line 114 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 15 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:212

Check warning on line 237 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 9 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:115

Check failure on line 109 in .mvn/wrapper/MavenWrapperDownloader.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CloseResource 

Ensure that resources like this ReadableByteChannel object are closed after use

Check warning on line 124 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 9 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:228

Check failure on line 111 in .mvn/wrapper/MavenWrapperDownloader.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CloseResource 

Ensure that resources like this FileOutputStream object are closed after use

Check warning on line 248 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 11 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:79

Check failure on line 58 in src/main/java/ar/com/nanotaboada/java/samples/spring/boot/services/BooksService.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

UnnecessaryAnnotationValueElement 

Avoid the use of value in annotations when its the only element

Check warning on line 90 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 11 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:237

Check failure on line 74 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenPost_whenRequestBodyContainsExistingValidBook_thenShouldReturnStatusConflict' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 35 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:28

Check failure on line 104 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenPost_whenRequestBodyContainsNewValidBook_thenShouldReturnStatusCreatedAndLocationHeader' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 131 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenPost_whenRequestBodyContainsInvalidBook_thenShouldReturnStatusBadRequest' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 35 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java:28
View more details on Codeac.io