Skip to content

refactor: migrate validations from services to controllers #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanotaboada merged 1 commit into from
Apr 19, 2025

refactor: migrate validations from services to controllers

2b44db7
Select commit
Loading
Failed to load commit list.
Merged

refactor: migrate validations from services to controllers #183

refactor: migrate validations from services to controllers
2b44db7
Select commit
Loading
Failed to load commit list.
Codeac.io / Codeac Code Quality succeeded Apr 19, 2025 in 29s

Codeac Code Quality

This PR contains 31 errors and 34 warnings.

Annotations

Check failure on line 276 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenPut_whenRequestBodyIsInvalidBook_thenResponseStatusIsBadRequest' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 303 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenDelete_whenPathVariableIsValidAndExistingISBN_thenResponseStatusIsNoContent' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 324 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenDelete_whenPathVariableIsValidButNonExistentISBN_thenResponseStatusIsNotFound' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 342 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenDelete_whenPathVariableIsInvalidISBN_thenResponseStatusIsBadRequest' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 34 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/repositories/BooksRepositoryTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenFindByIsbn_whenISBNAlreadyExists_thenShouldReturnExistingBook' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 44 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/repositories/BooksRepositoryTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenFindByIsbn_whenISBNDoesNotExist_thenShouldReturnEmptyOptional' doesn't match '[a-z][a-zA-Z0-9]*'

Check failure on line 61 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenCreate_whenRepositoryExistsByIdReturnsTrue_thenRepositoryNeverSaveBookAndResultIsFalse' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 172 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 8 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:75

Check failure on line 80 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenCreate_whenRepositoryExistsByIdReturnsFalse_thenRepositorySaveBookAndResultIsTrue' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 83 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 8 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:164

Check failure on line 105 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenRetrieveByIsbn_whenRepositoryFindByIdReturnsBook_thenResultIsEqualToBook' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 191 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:56

Check failure on line 120 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenRetrieveByIsbn_whenRepositoryFindByIdReturnsEmpty_thenResultIsNull' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 68 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:179

Check failure on line 143 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenRetrieveAll_whenRepositoryFindAllReturnsBooks_thenResultIsEqualToBooks' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 13 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:1

Check failure on line 169 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenUpdate_whenRepositoryExistsByIdReturnsTrue_thenRepositorySaveBookAndResultIsTrue' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 13 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java:1

Check failure on line 184 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenUpdate_whenRepositoryExistsByIdReturnsFalse_thenRepositoryNeverSaveBookAndResultIsFalse' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 36 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java:22

Check failure on line 205 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenDelete_whenRepositoryExistsByIdReturnsFalse_thenRepositoryNeverDeleteBookAndResultIsFalse' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 29 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 7 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java:29

Check failure on line 220 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/BooksServiceTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

MethodNamingConventions 

The JUnit 5 test method name 'givenDelete_whenRepositoryExistsByIdReturnsTrue_thenRepositoryDeleteBookAndResultIsTrue' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 256 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java:221

Check warning on line 233 in src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java

See this annotation in the file changed.

@codeac-io codeac-io / Codeac Code Quality

CodeDuplication 

This block of 12 lines is too similar to src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/BooksControllerTests.java:244
View more details on Codeac.io