ci(release): implement named releases with tag-based deployment (#252)#287
Conversation
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 8 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a tag-triggered CD workflow Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant Repo as "Git Repository"
participant Actions as "GitHub Actions"
participant Maven as "Maven Wrapper"
participant Buildx as "Docker Buildx"
participant GHCR as "ghcr.io"
participant Releases as "GitHub Release API"
Developer->>Repo: Push annotated tag v1.0.0-arsenal
Repo->>Actions: Trigger CD workflow (tag push)
Actions->>Actions: Parse tag -> semver (1.0.0), club (arsenal)
Actions->>Maven: Run ./mvnw clean verify
Maven-->>Actions: Build succeeds
Actions->>Buildx: Build multi-arch image (amd64, arm64)
Buildx->>GHCR: Push tags: 1.0.0, arsenal, latest
GHCR-->>Buildx: Push success
Actions->>Actions: Generate changelog (git diff / commit subjects)
Actions->>Releases: Create GitHub Release with changelog & pull instructions
Releases-->>Actions: Release created
Actions-->>Developer: Workflow complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Assessment against linked issues
Possibly related issues
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 28 28
===========================================
Files 2 2
Lines 77 77
Branches 8 8
===========================================
Hits 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/maven-cd.yml (1)
96-109: Changelog generation may produce unexpected results for edge cases.The
--sort=-version:refnamesort may not correctly order semantic versions in all cases (e.g.,v10.0.0may sort beforev2.0.0due to lexicographic comparison). Additionally, if the current tag is the first release,PREVIOUS_TAGwill be empty and the full commit history will be included.For a first release, the behavior is acceptable. For future robustness, consider using
--sort=-v:refnamewhich is the abbreviated form and should handle semver better in recent Git versions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/maven-cd.yml around lines 96 - 109, The changelog generation uses git tag sorting with "--sort=-version:refname" which can misorder semantic versions; update the invocation that sets PREVIOUS_TAG to use "--sort=-v:refname" instead to get proper semver-aware ordering, i.e., change the argument in the git tag command that assigns PREVIOUS_TAG; keep the existing fallback when PREVIOUS_TAG is empty so first-release behavior remains unchanged (refer to the PREVIOUS_TAG variable and the block that computes CHANGELOG).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/maven-cd.yml:
- Around line 91-94: The image tag lines use ${{ github.repository }} which can
contain uppercase characters; change each occurrence to use the toLower()
expression (e.g., ${{ toLower(github.repository) }}) so the three tags (the
multiline keys referencing ghcr.io/${{ github.repository }}:latest, ghcr.io/${{
github.repository }}:${{ steps.tag.outputs.semver }}, and ghcr.io/${{
github.repository }}:${{ steps.tag.outputs.club }}) are converted to lowercase
before composing the image names.
---
Nitpick comments:
In @.github/workflows/maven-cd.yml:
- Around line 96-109: The changelog generation uses git tag sorting with
"--sort=-version:refname" which can misorder semantic versions; update the
invocation that sets PREVIOUS_TAG to use "--sort=-v:refname" instead to get
proper semver-aware ordering, i.e., change the argument in the git tag command
that assigns PREVIOUS_TAG; keep the existing fallback when PREVIOUS_TAG is empty
so first-release behavior remains unchanged (refer to the PREVIOUS_TAG variable
and the block that computes CHANGELOG).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0442ee5e-2401-449d-8caa-e9c15ab95c15
📒 Files selected for processing (4)
.github/workflows/maven-cd.yml.github/workflows/maven-ci.ymlCHANGELOG.mdREADME.md
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/maven-cd.yml (1)
109-113: Prefer a unique delimiter for$GITHUB_OUTPUTmultiline values.Using a fixed
EOFdelimiter can break parsing if commit subjects contain that exact token.Suggested hardening
- { - echo "content<<EOF" - echo "$CHANGELOG" - echo "EOF" - } >> "$GITHUB_OUTPUT" + DELIM="CHANGELOG_$(date +%s%N)" + { + echo "content<<$DELIM" + echo "$CHANGELOG" + echo "$DELIM" + } >> "$GITHUB_OUTPUT"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/maven-cd.yml around lines 109 - 113, The current block appends a multiline value to GITHUB_OUTPUT using a fixed "EOF" delimiter which can break if the CHANGELOG contains that token; update the step that writes to GITHUB_OUTPUT to use a unique delimiter (e.g., build one from run-specific data or a hard-to-collide token) and use that same unique marker for both the start and end of the heredoc when emitting CHANGELOG, ensuring the variable name CHANGELOG and the GITHUB_OUTPUT append remain unchanged but the delimiter is collision-resistant.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/maven-cd.yml:
- Line 103: The current PREVIOUS_TAG assignment uses a regex exclusion (grep -v
"^${GITHUB_REF#refs/tags/}$") which can mis-match tags with dots; replace the
grep call to use fixed-string whole-line matching (e.g., change grep -v
"^${GITHUB_REF#refs/tags/}$" to grep -xv "${GITHUB_REF#refs/tags/}") so git tag
--sort=-version:refname | grep -xv "${GITHUB_REF#refs/tags/}" | head -n 1
reliably returns the previous tag.
---
Nitpick comments:
In @.github/workflows/maven-cd.yml:
- Around line 109-113: The current block appends a multiline value to
GITHUB_OUTPUT using a fixed "EOF" delimiter which can break if the CHANGELOG
contains that token; update the step that writes to GITHUB_OUTPUT to use a
unique delimiter (e.g., build one from run-specific data or a hard-to-collide
token) and use that same unique marker for both the start and end of the heredoc
when emitting CHANGELOG, ensuring the variable name CHANGELOG and the
GITHUB_OUTPUT append remain unchanged but the delimiter is collision-resistant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4cc7f7cd-23ad-4b8e-ba07-0f8ed23931e5
📒 Files selected for processing (1)
.github/workflows/maven-cd.yml
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
1 participant
Closes #252
This change is
Summary by CodeRabbit
New Features
Documentation
Chores