Skip to content

[codex] Add story settings and Moment links#13

Merged
jhull merged 2 commits into
mainfrom
codex/story-settings-moment-links
May 12, 2026
Merged

[codex] Add story settings and Moment links#13
jhull merged 2 commits into
mainfrom
codex/story-settings-moment-links

Conversation

@jhull

@jhull jhull commented May 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds optional story.settings[] as a reusable story-level Setting glossary.
  • Adds optional moment.setting_id so Moments can reference a shared Setting while keeping their required free-text setting field.
  • Updates schema docs, the main specification, and examples to show repeated Moment settings without duplicating place details.

Rationale

This accepts the useful part of the locations proposal while aligning it with existing NCP terminology. The concept maps to moment.setting, so the canonical field is settings, not locations. The shared glossary is story-level, while setting_id on Moments provides the explicit linkage when producers need it.

The change is additive: producers can keep emitting only free-text moment.setting; consumers that do not understand settings or setting_id can ignore them.

Validation

  • npm run validate:file -- examples/story-settings.json passed.
  • JSON/YAML schema twins compare equal via Ruby JSON.parse + YAML.load_file.
  • git diff --check passed.

Known existing suite state: npm run validate:schema still fails on pre-existing valid fixture/schema mismatches around Storybeat additional properties and two storypoint-throughline fixtures missing narrative titles. The new examples/story-settings.json fixture passes in that run.

@jhull jhull merged commit 4354ceb into main May 12, 2026
2 checks passed
@jhull jhull deleted the codex/story-settings-moment-links branch May 12, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant