rollback typing changes... as I cannot recall their reason

Author: FBruzzesi

src/narwhals/stable/v1/typing.py

@@ -8,12 +8,7 @@
 if TYPE_CHECKING:
     from typing import TypeAlias
 
-    from narwhals._native import (
-        NativeDataFrame,
-        NativeDuckDB,
-        NativeIbis,
-        NativeLazyFrame,
-    )
+    from narwhals._native import NativeDataFrame, NativeDuckDB, NativeLazyFrame
     from narwhals.stable.v1 import DataFrame, Expr, LazyFrame, Series
 
     class DataFrameLike(Protocol):
@@ -30,9 +25,7 @@ def __dataframe__(self, *args: Any, **kwargs: Any) -> Any: ...
 `nw.Expr`, e.g. `df.select('a')`.
 """
 
-IntoDataFrame: TypeAlias = Union[
-    "NativeDataFrame", "DataFrameLike", "NativeDuckDB", "NativeIbis"
-]
+IntoDataFrame: TypeAlias = Union["NativeDataFrame", "DataFrameLike", "NativeDuckDB"]
 """Anything which can be converted to a Narwhals DataFrame.
 
 Use this if your function accepts a narwhalifiable object but doesn't care about its backend.

src/narwhals/testing/asserts/frame.py

@@ -13,6 +13,7 @@
 
 if TYPE_CHECKING:
     from narwhals._typing import Arrow, IntoBackend, Pandas, Polars
+    from narwhals.typing import DataFrameT, LazyFrameT
 
 GUARANTEES_ROW_ORDER = {
     Implementation.PANDAS,
@@ -25,8 +26,8 @@
 
 
 def assert_frame_equal(
-    left: DataFrame[Any] | LazyFrame[Any],
-    right: DataFrame[Any] | LazyFrame[Any],
+    left: DataFrameT | LazyFrameT,
+    right: DataFrameT | LazyFrameT,
     *,
     check_row_order: bool = True,
     check_column_order: bool = True,
@@ -144,8 +145,8 @@ def assert_frame_equal(
 
 
 def _check_correct_input_type(  # noqa: RET503
-    left: DataFrame[Any] | LazyFrame[Any],
-    right: DataFrame[Any] | LazyFrame[Any],
+    left: DataFrameT | LazyFrameT,
+    right: DataFrameT | LazyFrameT,
     backend: IntoBackend[Polars | Pandas | Arrow] | None,
 ) -> tuple[DataFrame[Any], DataFrame[Any]]:
     # Adapted from https://github.com/pola-rs/polars/blob/afdbf3056d1228cf493901e45f536b0905cec8ea/py-polars/src/polars/testing/asserts/frame.py#L15-L17
@@ -164,8 +165,8 @@ def _check_correct_input_type(  # noqa: RET503
 
 
 def _assert_dataframe_equal(
-    left: DataFrame[Any],
-    right: DataFrame[Any],
+    left: DataFrameT,
+    right: DataFrameT,
     impl: Implementation,
     *,
     check_row_order: bool,
@@ -231,11 +232,7 @@ def _assert_dataframe_equal(
 
 
 def _check_schema_equal(
-    left: DataFrame[Any],
-    right: DataFrame[Any],
-    *,
-    check_dtypes: bool,
-    check_column_order: bool,
+    left: DataFrameT, right: DataFrameT, *, check_dtypes: bool, check_column_order: bool
 ) -> None:
     """Compares DataFrame schema based on specified criteria.
 

tests/testing/assert_frame_equal_test.py

@@ -41,7 +41,7 @@ def test_implementation_mismatch() -> None:
     import pyarrow as pa
 
     with _assertion_error("implementation mismatch"):
-        assert_frame_equal(
+        assert_frame_equal(  # type: ignore[type-var]
             nw.from_native(pd.DataFrame({"a": [1]})), nw.from_native(pa.table({"a": [1]}))
         )