Merge branch 'main' into feat/testing-constructors

Author: FBruzzesi

.github/workflows/deploy-docs.yml

@@ -32,7 +32,7 @@ jobs:
         uses: astral-sh/setup-uv@v7
       - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV
       - name: Install dependencies
-        run: uv pip install -e . --group docs
+        run: uv pip install -e ".[dask,ibis]" --group docs
       - name: Run hooks manually
         run: |
           python utils/generate_backend_completeness.py

Makefile

@@ -25,6 +25,8 @@ typing: ## Run typing checks
 		--editable test-plugin/. \
 		--editable . \
 		--group typing
+	# temporary pin due to https://github.com/narwhals-dev/narwhals/issues/3560
+	$(VENV_BIN)/uv pip install "pyarrow<24"
 	$(VENV_BIN)/uv run --no-sync pyright
 	$(VENV_BIN)/uv run --no-sync mypy
 
@@ -33,7 +35,7 @@ docs-serve:  # Build and serve the docs locally
 	$(VENV_BIN)/uv pip install \
 		--upgrade \
 		--editable test-plugin/. \
-		--editable . \
+		--editable ".[dask, ibis]" \
 		--group docs
 	$(VENV_BIN)/uv run --no-sync utils/generate_backend_completeness.py
 	$(VENV_BIN)/uv run --no-sync utils/generate_zen_content.py

pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "narwhals"
-version = "2.19.0"
+version = "2.20.0"
 dependencies = []
 requires-python = ">=3.9"
 authors = [
@@ -93,15 +93,10 @@ typing = [  # keep some of these pinned and bump periodically so there's fewer s
 docs = [
   "black",  # required by mkdocstrings_handlers
   "jinja2",
-  "duckdb",
-  "narwhals[sql]",
   "markdown-exec[ansi]",
   "mkdocs-autorefs",
   "mkdocstrings-python>=2.0.3",
-  "sqlframe",
-  "pandas",
-  "polars>=1.0.0",
-  "pyarrow",
+  "narwhals[duckdb,pandas,pyarrow,polars,sql,sqlframe]",
   "zensical>=0.0.28"
 ]
 dev = [

tests/expr_and_series/cast_test.py

@@ -217,9 +217,8 @@ def test_cast_datetime_tz_aware(
         or "ibis" in str(constructor)
     ):
         request.applymarker(pytest.mark.xfail)
-    request.applymarker(
-        pytest.mark.xfail(is_pyarrow_windows_no_tzdata(constructor), reason="no tzdata")
-    )
+    if is_pyarrow_windows_no_tzdata(constructor):
+        pytest.skip()
 
     data = {
         "date": [
@@ -247,9 +246,8 @@ def test_cast_datetime_utc(
         or "sqlframe" in str(constructor)
     ):
         request.applymarker(pytest.mark.xfail)
-    request.applymarker(
-        pytest.mark.xfail(is_pyarrow_windows_no_tzdata(constructor), reason="no tzdata")
-    )
+    if is_pyarrow_windows_no_tzdata(constructor):
+        pytest.skip()
 
     data = {
         "date": [

tests/frame/to_numpy_test.py

@@ -24,13 +24,11 @@ def test_to_numpy(constructor_eager: ConstructorEager) -> None:
     assert result.dtype == "float64"
 
 
-def test_to_numpy_tz_aware(
-    constructor_eager: ConstructorEager, request: pytest.FixtureRequest
-) -> None:
+def test_to_numpy_tz_aware(constructor_eager: ConstructorEager) -> None:
     if ("pandas_pyarrow" in str(constructor_eager) and PANDAS_VERSION < (2, 2)) or (
         "pyarrow" in str(constructor_eager) and is_windows()
     ):
-        request.applymarker(pytest.mark.xfail)
+        pytest.skip()
     df = nw.from_native(
         constructor_eager({"a": [datetime(2020, 1, 1), datetime(2020, 1, 2)]}),
         eager_only=True,

tests/selectors_test.py

@@ -85,14 +85,16 @@ def test_datetime(constructor: Constructor, request: pytest.FixtureRequest) -> N
         "pyspark" in str(constructor)
         or "duckdb" in str(constructor)
         or "dask" in str(constructor)
-        or ("pyarrow" in str(constructor) and is_windows())
-        or ("pandas" in str(constructor) and PANDAS_VERSION < (2,))
         or "ibis" in str(constructor)
         # https://github.com/pola-rs/polars/issues/23767
         # TODO(FBruzzesi): Manage polars version
         or ("polars" in str(constructor) and POLARS_VERSION >= (1, 32, 0))
     ):
         request.applymarker(pytest.mark.xfail)
+    if ("pyarrow" in str(constructor) and is_windows()) or (
+        "pandas" in str(constructor) and PANDAS_VERSION < (2,)
+    ):
+        pytest.skip()
     if "modin" in str(constructor):
         pytest.skip(reason="too slow")
 

tests/series_only/to_numpy_test.py

@@ -34,16 +34,13 @@ def test_to_numpy(
     assert_array_equal(s.to_numpy(), np.array(data, dtype=float))
 
 
-def test_to_numpy_tz_aware(
-    constructor_eager: ConstructorEager, request: pytest.FixtureRequest
-) -> None:
+def test_to_numpy_tz_aware(constructor_eager: ConstructorEager) -> None:
     if (
         ("pandas_pyarrow" in str(constructor_eager) and PANDAS_VERSION < (2, 2))
         or ("modin_pyarrow" in str(constructor_eager) and PANDAS_VERSION < (2, 2))
         or ("pyarrow" in str(constructor_eager) and is_windows())
     ):
-        request.applymarker(pytest.mark.xfail)
-        request.applymarker(pytest.mark.xfail)
+        pytest.skip()
     df = nw.from_native(
         constructor_eager({"a": [datetime(2020, 1, 1), datetime(2020, 1, 2)]}),
         eager_only=True,