Skip to content

deps: Drop support for python 3.9#3533

Open
FBruzzesi wants to merge 26 commits intomainfrom
deps/bump-py310
Open

deps: Drop support for python 3.9#3533
FBruzzesi wants to merge 26 commits intomainfrom
deps/bump-py310

Conversation

@FBruzzesi
Copy link
Copy Markdown
Member

@FBruzzesi FBruzzesi commented Apr 4, 2026

Description

It's likely that I have missed some branches that could be simplified due to newer python and bumping upstream min versions. Take this as a start to discuss in more detail

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

@FBruzzesi FBruzzesi added the dependencies Pull requests that update a dependency file label Apr 4, 2026
@FBruzzesi FBruzzesi marked this pull request as draft April 4, 2026 11:49
@dangotbanned

This comment was marked as outdated.

Sign in to view
@FBruzzesi
Copy link
Copy Markdown
Member Author

FBruzzesi commented Apr 6, 2026

How would you feel about making the zip_strict -> zip(strict=True) change a follow-up?

Oh man, yes we can do that! In a way that's the largest diff 🤣

RE: typing, do you have any time/willing to take a stab at it?

@dangotbanned

This comment was marked as resolved.

Sign in to view
dangotbanned
dangotbanned reviewed Apr 6, 2026
View reviewed changes
Comment thread narwhals/stable/v1/typing.py Outdated
dangotbanned
dangotbanned reviewed Apr 6, 2026
View reviewed changes
Comment thread .github/workflows/downstream_tests.yml Outdated
@dangotbanned

This comment was marked as outdated.

Sign in to view
@FBruzzesi FBruzzesi marked this pull request as ready for review April 12, 2026 18:43
@dangotbanned dangotbanned self-requested a review April 13, 2026 15:47
dangotbanned
dangotbanned approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FBruzzesi, really appreciate the slog you've gone through on this one 😍

hungry narwhal

As mentioned on discord, most of the suggestions are about this:

Current:

- zip(...)
+ zip(..., strict=True)

Proposed:

- zip(...)
+ zip(..., strict=False)

We can always make more of them strict later if needed 🙂

Note

zip_strict -> zip(..., strict=True) is all good

Comment thread .github/workflows/downstream_tests.yml Outdated
Comment thread narwhals/_pandas_like/series.py
Comment thread narwhals/_spark_like/expr.py Outdated
Comment thread narwhals/_spark_like/dataframe.py Outdated
Comment thread narwhals/_polars/dataframe.py Outdated
Comment thread narwhals/_dask/expr.py Outdated
Comment thread narwhals/_dask/dataframe.py Outdated
Comment thread narwhals/_dask/dataframe.py Outdated
Comment thread narwhals/_compliant/dataframe.py Outdated
Comment thread tests/conftest.py Outdated
@FBruzzesi
Copy link
Copy Markdown
Member Author

FBruzzesi commented Apr 14, 2026 •
edited
Loading

@MarcoGorelli let me know if you are happy with this.

I am happy to make a release before merging, so that some of the most recent features make it into a version that still support py3.9

@MarcoGorelli
Copy link
Copy Markdown
Member

MarcoGorelli commented May 1, 2026

yeah no objections from my end if you're both happy with this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dangotbanned dangotbanned dangotbanned approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.9

3 participants

@FBruzzesi @dangotbanned @MarcoGorelli