fix: Allow float('nan') as value in join for duckdb#3555
Merged
Conversation
MarcoGorelli
approved these changes
May 4, 2026
Comment on lines
+310
to
+313
| # Use `==` to preserve the polars semantic of `null != null` in joins, | ||
| # and additionally match `NaN = NaN` since `==` in DuckDB treats `NaN` | ||
| # like SQL `NULL` (see https://github.com/narwhals-dev/narwhals/issues/3554). | ||
| # `isnan` is safe to apply as it returns `false` for non-float columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It does not fully solve the issue but:
What type of PR is this? (check all applicable)
Related issues
joinonfloat("nan)behaves differently #3554Checklist