Fix off-by-one for GVCID parameter limits

Donnie-Ice · web-flow · commit ee42a6c386d3 · 2026-04-01T17:16:24.000-04:00
diff --git a/src/core/crypto_config.c b/src/core/crypto_config.c
@@ -886,7 +886,7 @@ int32_t Crypto_Config_Cam(uint8_t cam_enabled, char *cookie_file_path, char *key
 int32_t Crypto_Config_Add_TC_Gvcid_Managed_Parameters(TCGvcidManagedParameters_t gvcid_managed_parameters_struct)
 {
     int32_t status = CRYPTO_LIB_SUCCESS;
-    if (tc_gvcid_counter > GVCID_MAN_PARAM_SIZE)
+    if (tc_gvcid_counter >= GVCID_MAN_PARAM_SIZE)
     {
         status = CRYPTO_LIB_ERR_EXCEEDS_MANAGED_PARAMETER_MAX_LIMIT;
     }
@@ -902,7 +902,7 @@ int32_t Crypto_Config_Add_TC_Gvcid_Managed_Parameters(TCGvcidManagedParameters_t
 int32_t Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TMGvcidManagedParameters_t gvcid_managed_parameters_struct)
 {
     int32_t status = CRYPTO_LIB_SUCCESS;
-    if (tm_gvcid_counter > GVCID_MAN_PARAM_SIZE)
+    if (tm_gvcid_counter >= GVCID_MAN_PARAM_SIZE)
     {
         status = CRYPTO_LIB_ERR_EXCEEDS_MANAGED_PARAMETER_MAX_LIMIT;
     }

Original file line number	Diff line number	Diff line change
`@@ -886,7 +886,7 @@ int32_t Crypto_Config_Cam(uint8_t cam_enabled, char cookie_file_path, char key`
`886`	`886`	`int32_t Crypto_Config_Add_TC_Gvcid_Managed_Parameters(TCGvcidManagedParameters_t gvcid_managed_parameters_struct)`
`887`	`887`	`{`
`888`	`888`	`int32_t status = CRYPTO_LIB_SUCCESS;`
`889`		`- if (tc_gvcid_counter > GVCID_MAN_PARAM_SIZE)`
	`889`	`+ if (tc_gvcid_counter >= GVCID_MAN_PARAM_SIZE)`
`890`	`890`	`{`
`891`	`891`	`status = CRYPTO_LIB_ERR_EXCEEDS_MANAGED_PARAMETER_MAX_LIMIT;`
`892`	`892`	`}`
`@@ -902,7 +902,7 @@ int32_t Crypto_Config_Add_TC_Gvcid_Managed_Parameters(TCGvcidManagedParameters_t`
`902`	`902`	`int32_t Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TMGvcidManagedParameters_t gvcid_managed_parameters_struct)`
`903`	`903`	`{`
`904`	`904`	`int32_t status = CRYPTO_LIB_SUCCESS;`
`905`		`- if (tm_gvcid_counter > GVCID_MAN_PARAM_SIZE)`
	`905`	`+ if (tm_gvcid_counter >= GVCID_MAN_PARAM_SIZE)`
`906`	`906`	`{`
`907`	`907`	`status = CRYPTO_LIB_ERR_EXCEEDS_MANAGED_PARAMETER_MAX_LIMIT;`
`908`	`908`	`}`