463 resolve memory leaks in uts#464
Merged
Merged
Conversation
…ptoLib into 463-resolve-memory-leaks-in-uts
…ptoLib into 463-resolve-memory-leaks-in-uts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #464 +/- ##
==========================================
+ Coverage 75.97% 82.00% +6.02%
==========================================
Files 81 39 -42
Lines 22263 11945 -10318
Branches 1807 973 -834
==========================================
- Hits 16914 9795 -7119
+ Misses 4707 1778 -2929
+ Partials 642 372 -270 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dccutrig
approved these changes
May 12, 2025
…ptoLib into 463-resolve-memory-leaks-in-uts
rjbrown2
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?
Resolves all memory leaks in UTs. Currently has
-fsanitize=addressset in the CMakeLists file, so you should be able to just run the UTs and see if any fail. FHECF is also commented out in this as it repeatedly stomps on itself while calculating.