ci: declare workflow-level contents: read on 5 build/test workflows#2730
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare workflow-level contents: read on 5 build/test workflows#2730arpitjain099 wants to merge 1 commit into
contents: read on 5 build/test workflows#2730arpitjain099 wants to merge 1 commit into
Conversation
Pins the default GITHUB_TOKEN to contents: read on the 5 workflows in .github/workflows/ that don't actually need any write scope: - build-documentation.yml: doxygen build, upload as artifact. - code-coverage-eds.yml, code-coverage.yml: lcov coverage runs, no GitHub API. - format-check.yml: clang-format check. - static-analysis.yml: scan-build / cppcheck run. Left implicit on purpose: - add-to-project.yml is on pull_request_target with actions/add-to- project (needs projects: write). - icbundle.yml does git merge/push of PR sets via GITHUB_TOKEN. - mcdc.yml uses dawidd6/action-download-artifact (needs actions: read). - codeql-build.yml needs security-events: write. All of those are best hardened by a maintainer who knows the right scope. Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow caps bound runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and are credited per-file by the OpenSSF Scorecard Token-Permissions check. YAML validated locally with yaml.safe_load. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENtocontents: readon the 5 workflows in.github/workflows/that don't actually need any write scope:build-documentation.yml: doxygen build, uploads as workflow artifact.code-coverage-eds.yml,code-coverage.yml: lcov coverage runs, no GitHub API.format-check.yml: clang-format check.static-analysis.yml: scan-build / cppcheck.Left implicit on purpose:
add-to-project.ymlis onpull_request_targetwithactions/add-to-project, which needsprojects: write.icbundle.ymldoesgit merge+ push of PR sets viaGITHUB_TOKEN.mcdc.ymlusesdawidd6/action-download-artifact, which needsactions: read.codeql-build.ymlneedssecurity-events: writefor SARIF upload.All four are best declared by maintainers who know the right scope per workflow.
Why
CVE-2025-30066 (March 2025
tj-actions/changed-filessupply-chain compromise) exfiltratedGITHUB_TOKENfrom workflow logs and the leaked token retained whatever scope was issued at the workflow level. Pinning per workflow caps that runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF ScorecardToken-Permissionscheck.YAML validated locally with
yaml.safe_loadon each touched file.