Fix#2735, Set Default Time tm in CFE_TIME_Print#2747
Open
arielswalker wants to merge 1 commit into
Open
Conversation
arielswalker
force-pushed
the
fix-2735-set-default-time-tm
branch
2 times, most recently
from
1f9c49d to
a85119a
Compare
arielswalker
force-pushed
the
fix-2735-set-default-time-tm
branch
from
a85119a to
3cba9b6
Compare
arielswalker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #2735
Testing performed
Workflows and reran CodeSonar. CodeSonar analysis link provided in the internal GitHub issue.
Expected behavior changes
Resolve CodeSonar warning of Uninitialized Variable in cfe_time_api.c
System(s) tested on
GitHub Actions and CodeSonar
Additional context
Increased branch/line with if statement, therefore the code coverage workflows were updated.
Followed same solution as this PR.
Fixes the uninitialized variable issue, but adds new issues: Partially Uninitialized Aggregate, Use of <time.h> Time/Date Function, and Missing Literal Suffix - I can add CodeSonar Warning Suppression Comments if requested
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.