Merge pull request #1002 from nasa/issue-984-extern-param-defaults

Revise code generation for parameters

Author: thomas-bc

compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriter.scala

@@ -536,7 +536,6 @@ case class ComponentCppWriter (
             )
           ),
           List(s"Fw::${kindStr}ComponentBase(compName)") :::
-            (if (hasExternalParameters) List("paramDelegatePtr(nullptr)") else Nil) :::
             smInstancesByName.map { (name, smi) =>
               val sm = s.a.stateMachineMap(smi.symbol)
               val hasActionsOrGuards = sm.hasActions || sm.hasGuards
@@ -555,9 +554,6 @@ case class ComponentCppWriter (
               throttledEventsWithTimeout.map((_, event) => line(
                 s"this->${eventThrottleTimeName(event.getName)} = Fw::Time();"
               )),
-              sortedParams.flatMap((_, param) => guardedList(!param.isExternal) (
-                lines(s"this->${paramValidityFlagName(param.getName)} = Fw::ParamValid::UNINIT;")
-              ))
             )
           )
         ),

compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriterUtils.scala

@@ -964,6 +964,19 @@ abstract class ComponentCppWriterUtils(
     CppDoc.Function.PureVirtual
   )
 
+  def getValidityFlagForParam(param: Param) = {
+    val paramName = param.getName
+    val flagName = paramValidityFlagName(paramName)
+    linesClassMember(
+      lines(
+        s"""|
+            |//! The validity flag for $paramName
+            |Fw::ParamValid $flagName = Fw::ParamValid::UNINIT;
+            |"""
+      )
+    )
+  }
+
   /** Writes the type of a state machine implementation */
   def writeStateMachineImplType(smSymbol: Symbol.StateMachine) =
     StateMachine.getSymbolKind(smSymbol) match {