679 configure cryptolib#771
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #771 +/- ##
==========================================
- Coverage 73.64% 73.63% -0.01%
==========================================
Files 761 761
Lines 93984 93985 +1
Branches 7063 7063
==========================================
- Hits 69210 69206 -4
- Misses 24774 24779 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevincbruce
approved these changes
Aug 1, 2025
Contributor
kevincbruce
left a comment
kevincbruce
left a comment
There was a problem hiding this comment.
Changed ports around and verified working with cfdp/cryptolib tests.
Will-Matheny
approved these changes
Aug 5, 2025
Will-Matheny
left a comment
Will-Matheny
left a comment
There was a problem hiding this comment.
Used older JSTAR laptop, with and without shared folders. Deleted ports, and ran make, and still connected to cryptolib.
zlynch2
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR goals.
How to test?
scripts/env.shmake simfor radio ports andmake gswfor cryptolib portsSubmodule PRs and actions prior to closing this:
Closes #679 .