Cleanups

Remove an outdated comment from the zon file. Update patch to use "juicy
main's" arena allocator. Remove some unnecessary code in build.zig.

Removes the ziglua-c module. I do not believe anyone is using this. If
this feature is missing, I would rather make the import("c") in lib.zig
pub.

Author: natecraddock

build.zig

@@ -75,20 +75,10 @@ pub fn build(b: *Build) void {
             }),
         };
 
-        // Expose the Lua artifact, and get an install step that header translation can refer to
+        // Expose the Lua artifact.
         const install_lib = b.addInstallArtifact(lib, .{});
         b.getInstallStep().dependOn(&install_lib.step);
 
-        switch (lang) {
-            .luau => {
-                zlua.addIncludePath(upstream.path("Common/include"));
-                zlua.addIncludePath(upstream.path("Compiler/include"));
-                zlua.addIncludePath(upstream.path("Ast/include"));
-                zlua.addIncludePath(upstream.path("VM/include"));
-            },
-            else => zlua.addIncludePath(upstream.path("src")),
-        }
-
         zlua.linkLibrary(lib);
 
         // lib must expose all headers included by these root headers
@@ -112,10 +102,7 @@ pub fn build(b: *Build) void {
             t.addSystemIncludePath(additional_system_headers.?);
         }
 
-        const ziglua_c = t.mod;
-        b.modules.put(b.graph.arena, "ziglua-c", ziglua_c) catch @panic("OOM");
-
-        zlua.addImport("c", ziglua_c);
+        zlua.addImport("c", t.mod);
     }
 
     // Tests

build.zig.zon

@@ -5,10 +5,6 @@
     .paths = .{ "build.zig", "build.zig.zon", "src", "license", "build" },
 
     .dependencies = .{
-        // We do not use the lua.org version of Lua 5.1.5 because there is a known security issue
-        // (CVE-2014-5461) that will not be backported. This is the most resonable solution at
-        // the moment. Maybe there will be a way to apply a patch with the build system in the
-        // future.
         .lua51 = .{
             .url = "https://www.lua.org/ftp/lua-5.1.5.tar.gz",
             .hash = "N-V-__8AABAhDAAIlXL7OA-0Z5sWQh_FOFGoImvOvJzkRGOg",
@@ -50,6 +46,7 @@
             .hash = "N-V-__8AAFB1kwDHb7dLmDsOv91rOkqorfDB_2nJtqnp4F-b",
             .lazy = true,
         },
+
         .translate_c = .{
             .url = "git+https://codeberg.org/ziglang/translate-c#46b5609b5ac4c0a896217d1d984f3ae50e4810b5",
             .hash = "translate_c-0.0.0-Q_BUWpf0BgAwrh5AM-acJcslN_YPEhcoCVKbbNjwuUTJ",

build/patch.zig

@@ -1,16 +1,14 @@
 //! A simple script to apply a patch to a file
 //! Does minimal validation and is just enough for patching Lua 5.1
 
-pub fn main(init: std.process.Init.Minimal) !void {
-    var arena = std.heap.ArenaAllocator.init(std.heap.page_allocator);
-    defer arena.deinit();
-    const allocator = arena.allocator();
+pub fn main(init: std.process.Init) !void {
+    const arena = init.arena.allocator();
 
     var threaded: std.Io.Threaded = .init_single_threaded;
     defer threaded.deinit();
     const io = threaded.io();
 
-    var iter = try init.args.iterateAllocator(allocator);
+    var iter = try init.minimal.args.iterateAllocator(arena);
 
     // Skip executable name
     _ = iter.next();
@@ -26,9 +24,9 @@ pub fn main(init: std.process.Init.Minimal) !void {
         defer patch_file.close(io);
         var buf: [4096]u8 = undefined;
         var reader = patch_file.reader(io, &buf);
-        break :patch_file try reader.interface.allocRemaining(allocator, .unlimited);
+        break :patch_file try reader.interface.allocRemaining(arena, .unlimited);
     };
-    const chunk_details = Chunk.init(allocator, patch_file, 0) orelse @panic("No chunk data found");
+    const chunk_details = Chunk.init(arena, patch_file, 0) orelse @panic("No chunk data found");
 
     const file = try Io.Dir.cwd().openFile(io, file_path, .{ .mode = .read_only });
     defer file.close(io);