Skip to content

Commit 61f8ca4

Browse files
committed
fix(build): zig macos linker is not happy with luajit debug info
On master attempting to build -Dlang=luajit on macos (at least for arm64) hits an assert in Zig's MachO linker: thread 73187 panic: unexpected pointer encoding /home/bfredl/dev/zig/src/link/MachO/eh_frame.zig:33:21: 0x772f808 in parse (main.zig) @Panic("unexpected pointer encoding"); // TODO error ^ /home/bfredl/dev/zig/src/link/MachO/Object.zig:1125:22: 0x7732c1d in initEhFrameRecords (main.zig) try cie.parse(macho_file); ^ /home/bfredl/dev/zig/src/link/MachO/Object.zig:255:36: 0x7743887 in parse (main.zig) try self.initEhFrameRecords(gpa, index, handle, macho_file); ^ /home/bfredl/dev/zig/src/link/MachO/file.zig:336:35: 0x7745bd3 in parse (main.zig) .object => |x| x.parse(macho_file), ^ with some debugging this turns out to be the __eh_frame section which is generated in lj_vm.S. This debug info can be disabled at compile time using LJ_NO_UNWIND. Ideally this should be handled better upstream by omiting debug frames it does not understand instead of crashing the compiler, but for now this allows luajit to be used on macos at all.
1 parent fcf8ccc commit 61f8ca4

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

build/luajit.zig

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,10 @@ pub fn configure(b: *Build, target: Build.ResolvedTarget, optimize: std.builtin.
120120
else => &.{},
121121
};
122122

123-
const buildvm_windows_c_flags: []const []const u8 = if (target.result.os.tag == .windows)
123+
const buildvm_os_c_flags: []const []const u8 = if (target.result.os.tag == .windows)
124124
&.{"-DLUAJIT_OS=1"}
125+
else if (target.result.os.tag.isDarwin())
126+
&.{"-DLJ_NO_UNWIND=1"}
125127
else
126128
&.{};
127129

@@ -131,7 +133,7 @@ pub fn configure(b: *Build, target: Build.ResolvedTarget, optimize: std.builtin.
131133
.sub_path = "",
132134
} },
133135
.files = &.{ "src/host/buildvm_asm.c", "src/host/buildvm_fold.c", "src/host/buildvm_lib.c", "src/host/buildvm_peobj.c", "src/host/buildvm.c" },
134-
.flags = std.mem.concat(b.allocator, []const u8, &.{ buildvm_c_flags, buildvm_windows_c_flags }) catch @panic("OOM!"),
136+
.flags = std.mem.concat(b.allocator, []const u8, &.{ buildvm_c_flags, buildvm_os_c_flags }) catch @panic("OOM!"),
135137
});
136138

137139
buildvm.root_module.addIncludePath(upstream.path("src"));

0 commit comments

Comments
 (0)