Skip to content

Commit 5053c19

Browse files
natemcmasterclaude
andcommitted
fix: remove duplicate source files and XML doc warnings
Remove explicit AdditionalFiles entries for PublicAPI.*.txt files since Microsoft.CodeAnalysis.PublicApiAnalyzers includes them automatically. Remove redundant XML param tag that duplicated inheritdoc. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 13bc089 commit 5053c19

7 files changed

Lines changed: 4 additions & 30 deletions

build.ps1

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ if (!$Configuration) {
1616
$Configuration = if ($ci) { 'Release' } else { 'Debug' }
1717
}
1818

19-
if (-not (Test-Path variable:\IsCoreCLR)) {
20-
$IsWindows = $true
21-
}
22-
2319
$artifacts = "$PSScriptRoot/artifacts/"
2420

2521
Remove-Item -Recurse $artifacts -ErrorAction Ignore
@@ -36,14 +32,6 @@ exec dotnet tool run dotnet-format -- -v detailed @formatArgs "$PSScriptRoot/doc
3632
exec dotnet build --configuration $Configuration '-warnaserror:CS1591'
3733
exec dotnet pack --no-build --configuration $Configuration -o $artifacts
3834
exec dotnet build --configuration $Configuration "$PSScriptRoot/docs/samples/samples.sln"
39-
40-
[string[]] $testArgs=@()
41-
if (-not $IsWindows) {
42-
$testArgs += '-p:TestFullFramework=false'
43-
}
44-
45-
exec dotnet test --no-build --configuration $Configuration `
46-
--collect:"XPlat Code Coverage" `
47-
@testArgs
35+
exec dotnet test --no-build --configuration $Configuration --collect:"XPlat Code Coverage"
4836

4937
write-host -f green 'BUILD SUCCEEDED'

docs/api/McMaster.Extensions.CommandLineUtils.Conventions.CommandAttributeConvention.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ items:
5454
repo: https://github.com/natemcmaster/CommandLineUtils.git
5555
id: Apply
5656
path: ../src/CommandLineUtils/Conventions/CommandAttributeConvention.cs
57-
startLine: 21
57+
startLine: 17
5858
assemblies:
5959
- McMaster.Extensions.CommandLineUtils
6060
namespace: McMaster.Extensions.CommandLineUtils.Conventions

docs/generate.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ try {
1818

1919
$buildRoot = "$PSScriptRoot/../.build/docs"
2020
$targetDir = "$buildRoot/gh-pages"
21-
mkdir -p $buildRoot -ErrorAction Ignore | Out-Null
21+
New-Item -ItemType Directory -Path $buildRoot -Force | Out-Null
2222

2323
exec git worktree prune 2>&1 | out-null
2424
if (-not (git worktree list --porcelain | Select-String 'gh-pages')) {

docs/push.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#requires -version 5
1+
#!/usr/bin/env pwsh
22
param(
33
[string]$SourceCommit,
44
[string]$ApiToken,

src/CommandLineUtils/Conventions/CommandAttributeConvention.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ namespace McMaster.Extensions.CommandLineUtils.Conventions
1414
/// <seealso cref="McMaster.Extensions.CommandLineUtils.Conventions.IConvention" />
1515
public class CommandAttributeConvention : IConvention
1616
{
17-
/// <summary>
18-
/// Apply the convention.
19-
/// </summary>
20-
/// <param name="context">The context in which the convention is applied.</param>
2117
/// <inheritdoc />
2218
public virtual void Apply(ConventionContext context)
2319
{

src/CommandLineUtils/McMaster.Extensions.CommandLineUtils.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,4 @@ McMaster.Extensions.CommandLineUtils.ArgumentEscaper
3030
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="4.14.0" PrivateAssets="All" />
3131
</ItemGroup>
3232

33-
<ItemGroup>
34-
<AdditionalFiles Include="PublicAPI.Shipped.txt" />
35-
<AdditionalFiles Include="PublicAPI.Unshipped.txt" />
36-
</ItemGroup>
37-
3833
</Project>

src/Hosting.CommandLine/McMaster.Extensions.Hosting.CommandLine.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="4.14.0" PrivateAssets="All" />
1616
</ItemGroup>
1717

18-
<ItemGroup>
19-
<AdditionalFiles Include="PublicAPI.Shipped.txt" />
20-
<AdditionalFiles Include="PublicAPI.Unshipped.txt" />
21-
</ItemGroup>
22-
2318
<ItemGroup>
2419
<ProjectReference Include="..\CommandLineUtils\McMaster.Extensions.CommandLineUtils.csproj" />
2520
</ItemGroup>

0 commit comments

Comments
 (0)