better handle eslint not found on PATH

Author: natesilva

Commands/Automatically Fix Problems (ESLint).tmCommand

@@ -12,7 +12,12 @@
 set -f
 
 TPY=${TM_PYTHON:-python}
-"${TPY}" "${TM_BUNDLE_SUPPORT}/main.py" --fix
+OUTPUT=$("${TPY}" "${TM_BUNDLE_SUPPORT}/main.py" --fix)
+
+if [[ ${OUTPUT} == *"!DOCTYPE html"* ]]; then
+  exit_show_html "${OUTPUT}"
+fi
+
 </string>
 	<key>input</key>
 	<string>document</string>

Commands/Save & Validate with ESLint.tmCommand

@@ -13,6 +13,11 @@ set -f
 
 TPY=${TM_PYTHON:-python}
 OUTPUT=$("${TPY}" "${TM_BUNDLE_SUPPORT}/main.py")
+
+if [[ ${OUTPUT} == *"!DOCTYPE html"* ]]; then
+  exit_show_html "${OUTPUT}"
+fi
+
 if [[ "${OUTPUT}" = "" ]]; then
 	exit_discard
 else

Support/main.py

@@ -197,7 +197,21 @@ def fix():
     filename = os.environ['TM_FILEPATH']
     cwd = get_cwd()
 
-    the_validator.fix(filename, cwd)
+    try:
+        the_validator.fix(filename, cwd)
+    except validator.ValidateError as err:
+        context = {
+            'BASE_PATH': BASE_PATH,
+            'timestamp': time.strftime('%c'),
+            'errorMessage': err.message,
+        }
+        if err.path:
+            context['searchPath'] = err.path
+            html = ASHES_ENV.render('error_eslint_path.html', context)
+        else:
+            html = ASHES_ENV.render('error_eslint_other.html', context)
+        print(html)
+        sys.exit()
 
     mate = os.environ['TM_MATE']
     subprocess.call([mate, '--clear-mark=warning', filename])

Support/templates/error_eslint_path.html

@@ -28,7 +28,7 @@ <h4>How to fix it</h4><br>
         location of your <code>eslint</code> and <code>node</code> commands.
     </li>
 </ol><br>
-The path currently used by TextMate bundles is:<br>
+The path currently used to search for ESLint is:<br>
 <br>
 <div style="overflow:auto"><code>{searchPath|h}</code></div><br>
 <h4>How to disable validation</h4><br>

Support/validator.py

@@ -51,7 +51,7 @@ def fix(self, filename, cwd):
         try:
             subprocess.call(args, env=env, cwd=cwd)
         except OSError as err:
-            raise ValidateError(err.message, env['PATH'])
+            raise ValidateError(err.__str__(), env['PATH'])
 
 
     def run(self, input_iterable=sys.stdin, filename=None, input_is_html=False,