refactor: rename getDynamicReactNativeProps to getReactNativeProps for consistency

BREAKING CHANGE: rename `getDynamicReactNativeProps` to
`getReactNativeProps` for consistency

Author: jsamr

packages/transient-render-engine/src/model/HTMLElementModel.ts

@@ -91,7 +91,7 @@ export default class HTMLElementModel<
    * {@link TNode} attributes. For example, if you pass `accessibilityLabel`
    * and there is an `aria-label` attribute attached to one node, the
    * `aria-label` will be used. If you want to be able to override the
-   * `aria-label`, use {@link getDynamicReactNativeProps} instead.
+   * `aria-label`, use {@link getReactNativeProps} instead.
    */
   readonly reactNativeProps?: ReactNativePropsDefinitions;
   /**
@@ -125,7 +125,7 @@ export default class HTMLElementModel<
    * based on attributes (style, aria-* ...) and
    * {@link HTMLELementModel.reactNativeProps}.
    */
-  public readonly getDynamicReactNativeProps: NativeElementModel['getDynamicReactNativeProps'];
+  public readonly getReactNativeProps: NativeElementModel['getReactNativeProps'];
 
   /**
    * Derive markers for one TNode.
@@ -141,7 +141,7 @@ export default class HTMLElementModel<
     getUADerivedStyleFromAttributes,
     getMixedUAStyles,
     setMarkersForTNode,
-    getDynamicReactNativeProps,
+    getReactNativeProps,
     reactNativeProps
   }: HTMLElementModelProperties<T, M>) {
     this.tagName = tagName;
@@ -152,7 +152,7 @@ export default class HTMLElementModel<
     this.getUADerivedStyleFromAttributes = getUADerivedStyleFromAttributes;
     this.getMixedUAStyles = getMixedUAStyles;
     this.setMarkersForTNode = setMarkersForTNode;
-    this.getDynamicReactNativeProps = getDynamicReactNativeProps;
+    this.getReactNativeProps = getReactNativeProps;
     this.reactNativeProps = reactNativeProps;
   }
 

packages/transient-render-engine/src/model/defaultHTMLElementModels.ts

@@ -99,7 +99,7 @@ function headerStyle(
   };
 }
 
-const getDynamicReactNativePropsForHeading: ElementModelBase<any>['getDynamicReactNativeProps'] =
+const getReactNativePropsForHeading: ElementModelBase<any>['getReactNativeProps'] =
   ({ domNode }) => {
     const textLabel = textContent(domNode!);
     return {
@@ -111,8 +111,8 @@ const getDynamicReactNativePropsForHeading: ElementModelBase<any>['getDynamicRea
     };
   };
 
-const getDynamicReactNativePropsWithHref: ElementModelBase<any>['getDynamicReactNativeProps'] =
-  function getDynamicReactNativePropsWithHref({ attributes }) {
+const getReactNativePropsWithHref: ElementModelBase<any>['getReactNativeProps'] =
+  function getReactNativePropsWithHref({ attributes }) {
     if (typeof attributes.href === 'string' && attributes.href.length > 0) {
       return {
         native: {
@@ -152,37 +152,37 @@ const sectioningModelMap: HTMLModelRecord<
     category: 'sectioning',
     tagName: 'h1',
     mixedUAStyles: headerStyle('2em', '.67em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   h2: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
     tagName: 'h2',
     mixedUAStyles: headerStyle('1.5em', '.83em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   h3: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
     tagName: 'h3',
     mixedUAStyles: headerStyle('1.17em', '1em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   h4: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
     tagName: 'h4',
     mixedUAStyles: headerStyle('1em', '1.33em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   h5: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
     tagName: 'h5',
     mixedUAStyles: headerStyle('.83em', '1.67em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   h6: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
     tagName: 'h6',
     mixedUAStyles: headerStyle('.67em', '2.33em'),
-    getDynamicReactNativeProps: getDynamicReactNativePropsForHeading
+    getReactNativeProps: getReactNativePropsForHeading
   }),
   header: HTMLElementModel.fromNativeModel({
     category: 'sectioning',
@@ -210,7 +210,7 @@ const unsupportedModelMap: HTMLModelRecord<
     tagName: 'area',
     category: 'untranslatable',
     isVoid: true,
-    getDynamicReactNativeProps: getDynamicReactNativePropsWithHref
+    getReactNativeProps: getReactNativePropsWithHref
   }),
   map: HTMLElementModel.fromNativeModel({
     tagName: 'map',
@@ -556,7 +556,7 @@ const renderedEmbeddedModelMap: HTMLModelRecord<
     tagName: 'img',
     category: 'embedded',
     isVoid: true,
-    getDynamicReactNativeProps({ attributes }) {
+    getReactNativeProps({ attributes }) {
       // see https://w3c.github.io/html-aria/#el-img
       const label = attributes.alt || attributes['aria-label'];
       if (label) {
@@ -627,7 +627,7 @@ const emptyEmbeddedModelMap: HTMLModelRecord<
     category: 'embedded',
     isVoid: false, // allows svg elems
     isOpaque: true,
-    getDynamicReactNativeProps({ attributes }) {
+    getReactNativeProps({ attributes }) {
       if (attributes['aria-label']) {
         return {
           native: {
@@ -850,7 +850,7 @@ const defaultHTMLElementModels = {
         return anchorStyle;
       }
     },
-    getDynamicReactNativeProps: getDynamicReactNativePropsWithHref,
+    getReactNativeProps: getReactNativePropsWithHref,
     setMarkersForTNode(targetMarkers) {
       targetMarkers.anchor = true;
     }

packages/transient-render-engine/src/model/model-types.ts

@@ -208,7 +208,7 @@ export interface ElementModelBase<T extends string> {
    * {@link TNode} attributes. For example, if you pass `accessibilityLabel`
    * and there is an `aria-label` attribute attached to one node, the
    * `aria-label` will be used. If you want to be able to override the
-   * `aria-label`, use {@link getDynamicReactNativeProps} instead.
+   * `aria-label`, use {@link getReactNativeProps} instead.
    */
   readonly reactNativeProps?: ReactNativePropsDefinitions;
 
@@ -264,8 +264,8 @@ export interface ElementModelBase<T extends string> {
    * @param tnode - The TNode for which to create React Native props.
    * @param preGeneratedProps - The props that were pre-generated for the TNode based on attributes (style, aria-* ...) and {@link HTMLELementModel.reactNativeProps}.
    */
-  getDynamicReactNativeProps?: (
-    tnode: TNodeShape<TNodeType>,
+  getReactNativeProps?: (
+    tnode: ExtractTNodeFromType<TNodeType>,
     preGeneratedProps: ReactNativePropsSwitch | null,
     element: Element
   ) => ReactNativePropsDefinitions | null | undefined | void;

packages/transient-render-engine/src/tree/TNodeCtor.ts

@@ -157,15 +157,12 @@ const prototype: Omit<TNodeImpl, 'displayName' | 'type'> = {
 
   __generateDynamicNativePropsFromModel(autoGeneratedProps) {
     const elm = this.elementModel;
-    if (!elm || !elm.getDynamicReactNativeProps) {
+    if (!elm || !elm.getReactNativeProps) {
       return null;
     }
     return transformPropsDefinitionsToSwitch(
-      elm.getDynamicReactNativeProps(
-        this as any,
-        autoGeneratedProps,
-        this.domNode!
-      ) || null
+      elm.getReactNativeProps(this as any, autoGeneratedProps, this.domNode!) ||
+        null
     );
   },
 

packages/transient-render-engine/src/tree/__tests__/TNode.test.ts

@@ -85,7 +85,7 @@ describe('TNode class', () => {
     });
   });
   describe('getReactNativeProps', () => {
-    it("should return null when neither 'reactNativeProps' nor 'getDynamicReactNativeProps' are defined for this element model.", () => {
+    it("should return null when neither 'reactNativeProps' nor 'getReactNativeProps' are defined for this element model.", () => {
       const node = newTNode({
         elementModel: HTMLElementModel.fromCustomModel({
           tagName: 'foo',
@@ -119,12 +119,12 @@ describe('TNode class', () => {
         }
       });
     });
-    it("should support 'getDynamicReactNativeProps' returning null from the element model", () => {
+    it("should support 'getReactNativeProps' returning null from the element model", () => {
       const node = newTNode({
         elementModel: HTMLElementModel.fromCustomModel({
           contentModel: HTMLContentModel.block,
           tagName: 'foo',
-          getDynamicReactNativeProps() {
+          getReactNativeProps() {
             return null;
           }
         })
@@ -133,15 +133,15 @@ describe('TNode class', () => {
       // Test twice to make sure the cache is working
       expect(node.getReactNativeProps()).toBeNull();
     });
-    it("should support 'getDynamicReactNativeProps' returning non-null from the element model", () => {
+    it("should support 'getReactNativeProps' returning non-null from the element model", () => {
       const node = newTNode({
         domNode: new Element('foo', {
           'data-rn-accessibility-label': 'Hello'
         }),
         elementModel: HTMLElementModel.fromCustomModel({
           contentModel: HTMLContentModel.block,
           tagName: 'foo',
-          getDynamicReactNativeProps(tnode) {
+          getReactNativeProps(tnode) {
             if (tnode.attributes['data-rn-accessibility-label']) {
               return {
                 text: {
@@ -160,7 +160,7 @@ describe('TNode class', () => {
         view: {}
       });
     });
-    it("should merge props from 'reactNativeProps' and 'getDynamicReactNativeProps'", () => {
+    it("should merge props from 'reactNativeProps' and 'getReactNativeProps'", () => {
       const node = newTNode({
         domNode: new Element('foo', {
           class: 'header'
@@ -176,7 +176,7 @@ describe('TNode class', () => {
               testID: 'article-title'
             }
           },
-          getDynamicReactNativeProps(tnode) {
+          getReactNativeProps(tnode) {
             if (tnode.hasClass('header')) {
               return {
                 native: {