Commit 0d35787
Fix dead password tests and add ItemTag whitespace-name regression tests (#42)
Two bugs in test assertions found while auditing validators:
1. Three password tests in SignInEmailAndPasswordViewModelTest and
SignUpViewModelTest called hasInvalidDataEmail() instead of
hasInvalidDataPassword(). Email is blank by default in those setups,
so assertions passed for the wrong reason and the password rules
were never actually exercised. Pointed them at hasInvalidDataPassword().
2. Added whitespaceOnlyName_isInvalid regression tests for both
ItemTagCreateViewModel and ItemTagEditViewModel to lock in the
isBlank() name validation already in place.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent ba8248e commit 0d35787
4 files changed
Lines changed: 26 additions & 3 deletions
File tree
- app/src/test/kotlin/com/nativeapptemplate/nativeapptemplatefree/ui
- app_root
- shop_settings
- item_tag_detail
- item_tag_list
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
app/src/test/kotlin/com/nativeapptemplate/nativeapptemplatefree/ui/app_root/SignUpViewModelTest.kt
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
132 | 145 | | |
133 | 146 | | |
134 | 147 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
84 | 94 | | |
85 | 95 | | |
86 | 96 | | |
| |||
0 commit comments