Drop NFC-removal leftovers and tighten a few obvious patterns (#41)

- Delete CustomerScannedTag composable (dead since NFC/scan removal).
- Remove stale TODO marker in ShopDetailCardView left over from the
  schema-v2 drop of scanState/customerReadAt.
- Collapse NatConstants.baseUrlString into an expression-bodied
  function.
- Drop the redundant intermediate Flow vals (and now-unused imports)
  inside MainActivityViewModel.updatePermissions.

Mirrors NativeAppTemplate-Android#54.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: dadachi

app/src/main/kotlin/com/nativeapptemplate/nativeapptemplatefree/MainActivityViewModel.kt

@@ -6,10 +6,8 @@ import androidx.lifecycle.viewModelScope
 import com.nativeapptemplate.nativeapptemplatefree.MainActivityUiState.Loading
 import com.nativeapptemplate.nativeapptemplatefree.MainActivityUiState.Success
 import com.nativeapptemplate.nativeapptemplatefree.data.login.LoginRepository
-import com.nativeapptemplate.nativeapptemplatefree.model.Permissions
 import com.nativeapptemplate.nativeapptemplatefree.model.UserData
 import dagger.hilt.android.lifecycle.HiltViewModel
-import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.catch
@@ -43,19 +41,15 @@ class MainActivityViewModel @Inject constructor(
       val isLoggedIn = loginRepository.isLoggedIn().first()
 
       if (isLoggedIn) {
-        val permissionsFlow: Flow<Permissions> = loginRepository.getPermissions()
-
-        permissionsFlow
+        loginRepository.getPermissions()
           .catch { exception ->
             Log.e("MainActivityViewModel", "Failed to update permissions", exception)
 
-            val booleanFlow = loginRepository.logout()
-            booleanFlow
+            loginRepository.logout()
               .catch { logoutException ->
                 Log.e("MainActivityViewModel", "Logout error", logoutException)
               }
-              .collect {
-              }
+              .collect { }
           }
           .collect { permissions ->
             loginRepository.setPermissions(permissions)

app/src/main/kotlin/com/nativeapptemplate/nativeapptemplatefree/NatConstants.kt

@@ -17,13 +17,10 @@ object NatConstants {
   const val PLACEHOLDER_EMAIL: String = "you@example.com"
   const val PLACEHOLDER_PASSWORD: String = "password"
 
-  fun baseUrlString(): String {
-    val result = if (BuildConfig.PORT.isEmpty()) {
+  fun baseUrlString(): String =
+    if (BuildConfig.PORT.isEmpty()) {
       "${BuildConfig.SCHEME}://${BuildConfig.DOMAIN}"
     } else {
       "${BuildConfig.SCHEME}://${BuildConfig.DOMAIN}:${BuildConfig.PORT}"
     }
-
-    return result
-  }
 }

app/src/main/kotlin/com/nativeapptemplate/nativeapptemplatefree/ui/common/tags/CustomerScannedTag.kt

@@ -37,8 +37,6 @@ fun ShopDetailCardView(
         .padding(end = 8.dp),
     )
 
-    // TODO: removed in Phase 2A-2 — scanState/customerReadAt column dropped with ItemTag schema v2
-
     Column(
       horizontalAlignment = Alignment.End,
     ) {