Skip to content

Commit d986a81

Browse files
dadachiclaude
andauthored
Drop articles before renameable domain words (#51)
Apply SUBSTRATE-CONTRACT.md rule 1: UI strings and seed data must not couple articles to renameable domain nouns (Shop, ItemTag, Shopkeeper), so the agent's rename pipeline produces grammatical output for any target word. Mirrors nativeapptemplate/NativeAppTemplate-iOS#77. Of the 7 iOS UI string changes, 3 have Android equivalents in strings.xml; the other 4 are toast/error strings that don't exist on Android. The seed description fixtures (shop.json, shops.json) and the demo test that mirrors them are updated to match. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent f6531a1 commit d986a81

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

app/src/main/assets/shop.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"type": "shop",
55
"attributes": {
66
"name": "Shop1",
7-
"description": "This is a Shop1",
7+
"description": "This is Shop1",
88
"time_zone": "Tokyo"
99
},
1010
"meta": {

app/src/main/assets/shops.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"type": "shop",
66
"attributes": {
77
"name": "Shop1",
8-
"description": "This is a Shop1",
8+
"description": "This is Shop1",
99
"time_zone": "Tokyo"
1010
},
1111
"meta": {
@@ -18,7 +18,7 @@
1818
"type": "shop",
1919
"attributes": {
2020
"name": "Shop2",
21-
"description": "This is a Shop2",
21+
"description": "This is Shop2",
2222
"time_zone": "Tokyo"
2323
},
2424
"meta": {
@@ -31,7 +31,7 @@
3131
"type": "shop",
3232
"attributes": {
3333
"name": "Shop3",
34-
"description": "This is a Shop3",
34+
"description": "This is Shop3",
3535
"time_zone": "Tokyo"
3636
},
3737
"meta": {

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,13 @@
7878
<string name="shop_name_help">Name must be 1-%1$d characters.</string>
7979
<string name="shop_description_help">Description must be 0-%1$d characters.</string>
8080
<string name="add_shop_description">Add a new shop.</string>
81-
<string name="tap_shop_below">Tap a shop below</string>
81+
<string name="tap_shop_below">Tap shop below</string>
8282

8383
<!-- Shop Detail Screen -->
8484
<string name="message_shop_created">Shop added.</string>
8585
<string name="message_shop_deleted">Shop removed.</string>
8686
<string name="message_shop_updated">Shop updated.</string>
87-
<string name="shop_detail_instruction">Swipe an item tag to change its status.</string>
87+
<string name="shop_detail_instruction">Swipe to change item tag status.</string>
8888
<string name="complete">Complete</string>
8989
<string name="idle">Idle</string>
9090

@@ -101,7 +101,7 @@
101101
<string name="completed_at_label">Completed at</string>
102102
<string name="item_tag_name_placeholder">Buy milk</string>
103103
<string name="label_add_item_tag">Add Item Tag</string>
104-
<string name="add_item_tag_description">Add a new item tag and start changing the item tag status.</string>
104+
<string name="add_item_tag_description">Add a new item tag and start changing item tag status.</string>
105105
<string name="item_tag_name_is_invalid">Item tag name is invalid.</string>
106106
<string name="item_tag_description_is_invalid">Item tag description is invalid.</string>
107107
<string name="item_tag_name_help">Name must be 1-%1$d characters.</string>

app/src/test/kotlin/com/nativeapptemplate/nativeapptemplatefree/demo/shop/DemoShopRepositoryTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class DemoShopRepositoryTest {
2828
type = "shop",
2929
attributes = Attributes(
3030
name = "Shop1",
31-
description = "This is a Shop1",
31+
description = "This is Shop1",
3232
timeZone = "Tokyo",
3333
),
3434
meta = Meta(
@@ -70,7 +70,7 @@ class DemoShopRepositoryTest {
7070
ShopBody(
7171
shopBodyDetail = ShopBodyDetail(
7272
name = "Shop1",
73-
description = "This is a Shop1",
73+
description = "This is Shop1",
7474
timeZone = "Tokyo",
7575
),
7676
),
@@ -87,7 +87,7 @@ class DemoShopRepositoryTest {
8787
shopUpdateBody = ShopUpdateBody(
8888
shopUpdateBodyDetail = ShopUpdateBodyDetail(
8989
name = "Shop1",
90-
description = "This is a Shop1",
90+
description = "This is Shop1",
9191
timeZone = "Tokyo",
9292
),
9393
),

0 commit comments

Comments
 (0)