Skip to content

Commit 0ac0bd8

Browse files
authored
Merge pull request #44 from nativeapptemplate/substrate-v2--silence-tag-success-toasts
Silence success toasts on item-tag complete/idle in ShopDetailView
2 parents d692de1 + a875d76 commit 0ac0bd8

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

NativeAppTemplate/Constants.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,7 @@ extension String {
204204
static let itemTagUpdated = "Tag updated successfully."
205205
static let itemTagDeleted = "Tag deleted successfully."
206206
static let itemTagDeletedError = "There was a problem deleting the tag."
207-
static let itemTagCompleted = "Tag completed successfully."
208207
static let itemTagCompletedError = "There was a problem completing the tag."
209-
static let itemTagIdled = "Tag idled successfully."
210208
static let itemTagIdledError = "There was a problem idling the tag."
211209

212210
static let shopkeeperCreated = "Account created successfully."

NativeAppTemplate/UI/Shop Detail/ShopDetailViewModel.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ final class ShopDetailViewModel {
7676

7777
do {
7878
_ = try await itemTagRepository.complete(id: itemTagId)
79-
messageBus.post(message: Message(level: .success, message: .itemTagCompleted))
8079
} catch {
8180
messageBus.post(
8281
message: Message(
@@ -98,7 +97,6 @@ final class ShopDetailViewModel {
9897

9998
do {
10099
_ = try await itemTagRepository.idle(id: itemTagId)
101-
messageBus.post(message: Message(level: .success, message: .itemTagIdled))
102100
} catch {
103101
messageBus.post(
104102
message: Message(

NativeAppTemplateTests/UI/Shop Detail/ShopDetailViewModelTest.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,7 @@ struct ShopDetailViewModelTest { // swiftlint:disable:this type_body_length
143143
}
144144
await completeTagTask.value
145145

146-
let message = String.itemTagCompleted
147-
148-
#expect(viewModel.messageBus.currentMessage?.message == message)
146+
#expect(viewModel.messageBus.currentMessage == nil)
149147
}
150148

151149
@Test
@@ -211,9 +209,7 @@ struct ShopDetailViewModelTest { // swiftlint:disable:this type_body_length
211209
}
212210
await idleTagTask.value
213211

214-
let message = String.itemTagIdled
215-
216-
#expect(viewModel.messageBus.currentMessage?.message == message)
212+
#expect(viewModel.messageBus.currentMessage == nil)
217213
}
218214

219215
@Test

0 commit comments

Comments
 (0)