Merge pull request #49 from nativeapptemplate/substrate-v2--drop-maximum-name-length-from-permissions

Drop maximum_name_length from permissions; move to Constants

Author: dadachi

NativeAppTemplate/App.swift

@@ -36,7 +36,6 @@ private final class NullSessionController: SessionControllerProtocol {
     var shouldUpdateApp: Bool = false
     var shouldUpdatePrivacy: Bool = false
     var shouldUpdateTerms: Bool = false
-    var maximumNameLength: Int = 100
     var shopLimitCount: Int = 0
     var shopkeeper: Shopkeeper?
     var hasPermissions: Bool {

NativeAppTemplate/Constants.swift

@@ -74,6 +74,7 @@ enum NativeAppTemplateConstants {
 
     // MARK: - ItemTag
 
+    static let maximumItemTagNameLength = 100
     static let maximumItemTagDescriptionLength = 1_000
 
     // MARK: - Corner Radius

NativeAppTemplate/Networking/Requests/PermissionsRequest.swift

@@ -9,7 +9,6 @@ struct PermissionsResponse: Sendable {
     var iosAppVersion: Int
     var shouldUpdatePrivacy: Bool
     var shouldUpdateTerms: Bool
-    var maximumNameLength: Int
     var shopLimitCount: Int
 }
 
@@ -49,8 +48,6 @@ struct PermissionsRequest: Request {
             throw NativeAppTemplateAPIError.responseMissingRequiredMeta(field: "should_update_terms")
         }
 
-        let maximumNameLength = doc.meta["maximum_name_length"] as? Int ?? 100
-
         guard let shopLimitCount = doc.meta["shop_limit_count"] as? Int else {
             throw NativeAppTemplateAPIError.responseMissingRequiredMeta(field: "shop_limit_count")
         }
@@ -59,7 +56,6 @@ struct PermissionsRequest: Request {
             iosAppVersion: iosAppVersion,
             shouldUpdatePrivacy: shouldUpdatePrivacy,
             shouldUpdateTerms: shouldUpdateTerms,
-            maximumNameLength: maximumNameLength,
             shopLimitCount: shopLimitCount
         )
     }

NativeAppTemplate/Sessions/SessionController.swift

@@ -18,7 +18,6 @@ import Observation
     var shouldUpdateApp = false
     var shouldUpdatePrivacy = false
     var shouldUpdateTerms = false
-    var maximumNameLength = 100
     var shopLimitCount = 0
 
     var shopkeeper: Shopkeeper? {
@@ -171,8 +170,6 @@ import Observation
                 shouldUpdateApp = Int(Bundle.main.appBuild)! < permissionsResponse.iosAppVersion
                 shouldUpdatePrivacy = permissionsResponse.shouldUpdatePrivacy
                 shouldUpdateTerms = permissionsResponse.shouldUpdateTerms
-                maximumNameLength = permissionsResponse.maximumNameLength
-
                 shopLimitCount = permissionsResponse.shopLimitCount
 
                 didFetchPermissions = true

NativeAppTemplate/Sessions/SessionControllerProtocol.swift

@@ -38,7 +38,6 @@ protocol SessionControllerProtocol: AnyObject, Observable, Sendable {
     var shouldUpdateApp: Bool { get set }
     var shouldUpdatePrivacy: Bool { get set }
     var shouldUpdateTerms: Bool { get set }
-    var maximumNameLength: Int { get set }
     var shopLimitCount: Int { get set }
 
     var shopkeeper: Shopkeeper? { get set }

NativeAppTemplate/UI/Shop Settings/ItemTag Detail/ItemTagDetailView.swift

@@ -61,7 +61,6 @@ private extension ItemTagDetailView {
                     viewModel: ItemTagEditViewModel(
                         itemTagRepository: dataManager.itemTagRepository,
                         messageBus: messageBus,
-                        sessionController: dataManager.sessionController,
                         itemTagId: viewModel.itemTagId
                     )
                 )

NativeAppTemplate/UI/Shop Settings/ItemTag Detail/ItemTagEditViewModel.swift

@@ -18,18 +18,15 @@ final class ItemTagEditViewModel {
 
     private let itemTagRepository: ItemTagRepositoryProtocol
     private let messageBus: MessageBus
-    private let sessionController: SessionControllerProtocol
     private let itemTagId: String
 
     init(
         itemTagRepository: ItemTagRepositoryProtocol,
         messageBus: MessageBus,
-        sessionController: SessionControllerProtocol,
         itemTagId: String
     ) {
         self.itemTagRepository = itemTagRepository
         self.messageBus = messageBus
-        self.sessionController = sessionController
         self.itemTagId = itemTagId
     }
 
@@ -70,7 +67,7 @@ final class ItemTagEditViewModel {
     }
 
     var maximumNameLength: Int {
-        sessionController.maximumNameLength
+        NativeAppTemplateConstants.maximumItemTagNameLength
     }
 
     var maximumDescriptionLength: Int {

NativeAppTemplate/UI/Shop Settings/ItemTag List/ItemTagCreateViewModel.swift

@@ -16,18 +16,15 @@ final class ItemTagCreateViewModel {
 
     private let itemTagRepository: ItemTagRepositoryProtocol
     private let messageBus: MessageBus
-    private let sessionController: SessionControllerProtocol
     private let shopId: String
 
     init(
         itemTagRepository: ItemTagRepositoryProtocol,
         messageBus: MessageBus,
-        sessionController: SessionControllerProtocol,
         shopId: String
     ) {
         self.itemTagRepository = itemTagRepository
         self.messageBus = messageBus
-        self.sessionController = sessionController
         self.shopId = shopId
     }
 
@@ -54,7 +51,7 @@ final class ItemTagCreateViewModel {
     }
 
     var maximumNameLength: Int {
-        sessionController.maximumNameLength
+        NativeAppTemplateConstants.maximumItemTagNameLength
     }
 
     var maximumDescriptionLength: Int {

NativeAppTemplate/UI/Shop Settings/ItemTag List/ItemTagListView.swift

@@ -111,7 +111,6 @@ private extension ItemTagListView {
                     viewModel: ItemTagCreateViewModel(
                         itemTagRepository: dataManager.itemTagRepository,
                         messageBus: messageBus,
-                        sessionController: dataManager.sessionController,
                         shopId: viewModel.shop.id
                     )
                 )

NativeAppTemplateTests/Testing/Repositories/TestSessionController.swift

@@ -21,7 +21,6 @@ import Foundation
     public var shouldUpdateTerms: Bool = false
     public var shouldThrowPrivacyError: Bool = false
     public var shouldThrowTermsError: Bool = false
-    public var maximumNameLength: Int = 100
     public var shopLimitCount: Int = 1
 
     public var shopkeeper: Shopkeeper?