Merge pull request #21 from nativeapptemplate/secure-console-logs

Prevent sensitive data from leaking to iOS console in Release builds

Author: dadachi

NativeAppTemplate/Logging/Logger.swift

@@ -3,6 +3,10 @@
 //  NativeAppTemplate
 //
 
+import os
+
+private let appLogger = os.Logger(subsystem: "com.nativeapptemplate", category: "app")
+
 struct Failure {
     static func signUp(from source: (some Any).Type, reason: String) -> Self {
         .init(source: source, action: "signUp", reason: reason)
@@ -63,12 +67,12 @@ struct Failure {
     private let reason: String
 
     func log() {
-        print(
-            [
-                "source": source,
-                "action": action,
-                "reason": reason
-            ]
+        appLogger.error(
+            """
+            \(self.action, privacy: .public) \
+            source=\(self.source, privacy: .public) \
+            reason=\(self.reason, privacy: .private)
+            """
         )
     }
 }
@@ -95,6 +99,6 @@ struct Event {
     private let action: String
 
     func log() {
-        print("EVENT:: \(["source": source, "action": action])")
+        appLogger.info("EVENT:: source: \(self.source, privacy: .public), action: \(self.action, privacy: .public)")
     }
 }

NativeAppTemplate/Login/LoginRepository.swift

@@ -18,7 +18,9 @@ import Foundation
                 let loggedInShopkeeper = try keychainStore.retrieve()
                 _currentShopkeeper = Shopkeeper(from: loggedInShopkeeper)
             } catch {
+                #if DEBUG
                 print(error)
+                #endif
             }
         }
         return _currentShopkeeper
@@ -86,7 +88,9 @@ import Foundation
         do {
             try keychainStore.remove()
         } catch {
+            #if DEBUG
             print(error)
+            #endif
         }
     }
 }

NativeAppTemplate/Login/SignUpRepository.swift

@@ -100,7 +100,9 @@ import Foundation
         do {
             try keychainStore.remove()
         } catch {
+            #if DEBUG
             print(error)
+            #endif
         }
     }
 }

NativeAppTemplate/NFCManager.swift

@@ -205,7 +205,9 @@ extension NFCManager: NFCNDEFReaderSessionDelegate {
             isLock: isLock
         ) { error in
             guard error == nil else { return }
+            #if DEBUG
             print(">>> Write: \(userNdefMessage)")
+            #endif
         }
     }
 
@@ -263,6 +265,8 @@ extension NFCManager: NFCNDEFReaderSessionDelegate {
     func readerSessionDidBecomeActive(_ session: NFCNDEFReaderSession) {}
 
     func readerSession(_ session: NFCNDEFReaderSession, didInvalidateWithError error: Error) {
+        #if DEBUG
         print("readerSession error: \(error.localizedDescription)")
+        #endif
     }
 }

NativeAppTemplate/Persistence/KeychainStore/KeychainStore.swift

@@ -60,7 +60,9 @@ extension KeychainStore {
 
     func store(_ data: DataType) throws {
         let archived: Data
+        #if DEBUG
         print("data: \(data)")
+        #endif
         do {
             archived = try NSKeyedArchiver.archivedData(withRootObject: data, requiringSecureCoding: true)
         } catch {

NativeAppTemplate/Utilities/Utility.swift

@@ -75,12 +75,16 @@ enum Utility {
                 if let itemTagId = item.value {
                     itemTagInfo.id = itemTagId
                 }
+                #if DEBUG
                 print("item_tag_id: \(String(describing: itemTagInfo.id))")
+                #endif
             case "type":
                 if let type = item.value {
                     itemTagInfo.type = type
                 }
+                #if DEBUG
                 print("type: \(String(describing: itemTagInfo.type))")
+                #endif
             default:
                 break
             }