docs(README): correct step 5 to build/boot checks, not test suites#117
Merged
Conversation
Step 5 claimed `bin/rails test`, `xcodebuild test`, and `./gradlew test` must pass. Layer 2 Stage 1 (src/validation/layer2.ts) actually runs build/boot checks — `bin/rails db:prepare` + runner smoke, `xcodebuild build`, `./gradlew assembleDebug` — and deliberately avoids the heavy Rails test suite. Align the README with what the code does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
README step 5 ("Drive the build green") claimed the agent runs
bin/rails test,xcodebuild test, and./gradlew testbefore exiting.That's not what the code does. Layer 2 Stage 1 (
src/validation/layer2.ts) runs build/boot checks, not the native test suites:bin/rails testbin/rails db:prepare+bin/rails runnersmoke checkxcodebuild testxcodebuild build -scheme …./gradlew test./gradlew assembleDebug --no-daemonThe Rails suite is deliberately avoided there as "too heavy" (
layer2.ts:70). Runtime CRUD behavior is checked separately by Stage 2 via mobile-mcp.Change
One-line fix to step 5 so the README matches reality. Steps 2/3/4/6 were audited and are accurate.
🤖 Generated with Claude Code