docs(README): clarify step 5 fast gate vs VISUAL>=1 build mode#119
Merged
Conversation
Step 5 described only the build-mode Layer 2 commands (xcodebuild build, gradlew assembleDebug, rails db:prepare+runner) and presented them as the unconditional exit gate. Those only run when NATIVEAPPTEMPLATE_VISUAL>=1 (src/dispatch.ts:143 forces build mode). At the default VISUAL=0, Layer 2 runs in fast mode — bin/rails routes, xcodebuild -list, ./gradlew --version — a lighter probe, no full build. Spell out both paths to match the Runtime table and the VISUAL=1 flag doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Step 5 ("Drive the build green") listed only the build-mode Layer 2 commands —
bin/rails db:prepare+runner,xcodebuild build,./gradlew assembleDebug— and presented them as the unconditional exit gate.Those only run when
NATIVEAPPTEMPLATE_VISUAL>=1.src/dispatch.ts:143:At the default
VISUAL=0, Layer 2 runs in fast mode (src/validation/layer2.ts):VISUAL>=1(build)bin/rails routesbin/rails db:prepare+bin/rails runner 'puts OK'xcodebuild -listxcodebuild build -scheme …./gradlew --version./gradlew assembleDebug --no-daemonChange
Reword step 5 to describe both the default fast gate and the
VISUAL=1+ escalation, matching the Runtime table (line ~126) and theVISUAL=1flag doc (line ~218), which already state this correctly.🤖 Generated with Claude Code