Fix push notification delivery crashing on send (#71)

ItemTagNotifier's action_push_native config omitted the with_apple,
with_google, and with_data options. Noticed's delivery method passes
each to ActionPushNative, which does {}.merge(option) and raises
TypeError (no implicit conversion of nil into Hash) when the option is
nil. Provide the options (empty hashes for apple/google, the url payload
for data), matching Noticed's canonical config.

That crash masked a second bug: url referenced
api_v1_shopkeeper_shop_item_tag_path, which does not exist because
item_tags is declared shallow. Use the shallow helper
api_v1_shopkeeper_item_tag_path.

Existing tests only enqueued the notification and never performed the
delivery job, so neither bug surfaced. Add a test that performs the
delivery (excluding the real APNs/FCM send job) plus a test pinning the
url to the shallow route.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: dadachi

app/notifiers/item_tag_notifier.rb

@@ -4,10 +4,12 @@ class ItemTagNotifier < ApplicationNotifier
     config.format = -> {
       {
         title: title,
-        body: body,
-        data: {url: url}
+        body: body
       }
     }
+    config.with_data = -> { {url: url} }
+    config.with_apple = -> { {} }
+    config.with_google = -> { {} }
   end
 
   notification_methods do
@@ -20,10 +22,7 @@ def body
     end
 
     def url
-      Rails.application.routes.url_helpers.api_v1_shopkeeper_shop_item_tag_path(
-        shop_id: record.shop_id,
-        id: record.id
-      )
+      Rails.application.routes.url_helpers.api_v1_shopkeeper_item_tag_path(record.id)
     end
   end
 end

test/notifiers/item_tag_notifier_test.rb

@@ -1,6 +1,8 @@
 require "test_helper"
 
 class ItemTagNotifierTest < ActiveSupport::TestCase
+  include ActiveJob::TestHelper
+
   setup do
     @shopkeeper = shopkeepers(:one)
     @shopkeeper.create_default_account
@@ -30,4 +32,24 @@ class ItemTagNotifierTest < ActiveSupport::TestCase
     assert_equal I18n.t("notifiers.item_tag.title", shop: @shop.name), notification.title
     assert_equal I18n.t("notifiers.item_tag.body", name: @item_tag.name), notification.body
   end
+
+  test "url resolves to the shallow item_tag path" do
+    ItemTagNotifier.with(record: @item_tag).deliver(@shopkeeper)
+    notification = @shopkeeper.notifications.last
+
+    expected = Rails.application.routes.url_helpers.api_v1_shopkeeper_item_tag_path(@item_tag.id)
+    assert_equal expected, notification.url
+  end
+
+  test "action_push_native delivery performs without raising" do
+    ApplicationPushDevice.create!(owner: @shopkeeper, platform: "apple", token: "test-token")
+
+    # Performs the Noticed delivery job (where the payload is built) but not the
+    # ApplicationPushNotificationJob, so no real APNs/FCM request is made.
+    assert_nothing_raised do
+      perform_enqueued_jobs(except: ApplicationPushNotificationJob) do
+        ItemTagNotifier.with(record: @item_tag).deliver(@shopkeeper)
+      end
+    end
+  end
 end