Generalize notifier: drop "Called" + state-verb copy (rename-resistant)

Reverses the previous "Number → name" / "is ready" decision once it
became clear that any state-verb baked into the substrate's notifier
title or class name fights the agent's domain-adapt step. The agent
extends/renames the AASM state machine per spec (idled/completed →
e.g. waiting/seated for restaurant, pending/seen for vet clinic), but
its rename plan only handles the four model-level tokens (Shop /
Shopkeeper / ItemTag / NativeAppTemplate). State names cascading into
notifier file/class/locale-key/title are out of scope for the
rename-safety contract (#57).

So the substrate's notifier ships state-verb-free:

- File:        item_tag_called_notifier.rb → item_tag_notifier.rb
- Class:       ItemTagCalledNotifier       → ItemTagNotifier
- Locale key:  notifiers.item_tag_called   → notifiers.item_tag
- Title:       "%{name} is ready"          → "%{name}"
- Body:        "Please proceed to %{shop}." → "%{shop}"

`ItemTag` itself IS in the rename plan, so file/class/locale-key
cascade through `item_tag → patient/reservation/todo` cleanly.
`%{name}` and `%{shop}` are interpolation keys, not renameable
tokens. Result: substrate copy survives any state-verb rewrite the
agent's adapt step does, at the cost of vague substrate copy. The
adapt step can rewrite richer per-domain copy when it wants.

Tests + rubocop clean.

Author: dadachi

CHANGELOG.md

@@ -7,10 +7,10 @@
 - Add push notifications scaffolding via `noticed` v2 (#58)
 - New `Device` model + migration (UUID primary key, unique on `[platform, token]`, `last_active_at` for staleness scope)
 - New `Api::V1::Shopkeeper::DevicesController` — POST `/devices` is idempotent upsert (rebinds token to current shopkeeper); DELETE `/devices/:id` unregisters
-- Add `ApplicationNotifier` base class + example `ItemTagCalledNotifier` with `deliver_by :action_push_native` wiring (Apple + Google push via Rails-native `action_push_native` 0.3.x)
+- Add `ApplicationNotifier` base class + example `ItemTagNotifier` with `deliver_by :action_push_native` wiring (Apple + Google push via Rails-native `action_push_native` 0.3.x)
 - Generate `ApplicationPushNotification` / `ApplicationPushDevice` / `ApplicationPushNotificationJob` and `config/push.yml` (APNs/FCM credentials still placeholders — provision via `bin/rails credentials:edit` before enabling delivery; ItemTag AASM trigger lands in a follow-up)
 - Note: the existing `Device` registration API (`POST /api/v1/shopkeeper/devices`) writes to the custom `Device` model, not `ApplicationPushDevice` — bridging the two (so registered tokens flow into Action Push Native delivery) is a follow-up
-- `Shopkeeper has_many :devices, :notifications`; new locale entries under `notifiers.item_tag_called`
+- `Shopkeeper has_many :devices, :notifications`; new locale entries under `notifiers.item_tag` — title/body deliberately kept generic (`%{name}` / `%{shop}` only, no state-verbs like "completed" or "ready") so the agent's domain-adapt step can rewrite richer per-domain copy without fighting baked-in queue semantics
 - 21 new test runs (Device model + DevicesController + notifier); full suite still 0 failures
 
 ## 2026-05-02

app/notifiers/item_tag_called_notifier.rb app/notifiers/item_tag_notifier.rbapp/notifiers/item_tag_called_notifier.rb renamed to app/notifiers/item_tag_notifier.rb

@@ -1,4 +1,4 @@
-class ItemTagCalledNotifier < ApplicationNotifier
+class ItemTagNotifier < ApplicationNotifier
   deliver_by :action_push_native do |config|
     config.devices = -> { ApplicationPushDevice.where(owner: recipient) }
     config.format = -> {
@@ -12,11 +12,11 @@ class ItemTagCalledNotifier < ApplicationNotifier
 
   notification_methods do
     def title
-      I18n.t("notifiers.item_tag_called.title", name: record.name)
+      I18n.t("notifiers.item_tag.title", name: record.name)
     end
 
     def body
-      I18n.t("notifiers.item_tag_called.body", shop: record.shop.name)
+      I18n.t("notifiers.item_tag.body", shop: record.shop.name)
     end
 
     def url

config/locales/en.yml

@@ -41,9 +41,9 @@ en:
   default_shop_description: "This is a sample shop.\nYou can update or remove this shop."
 
   notifiers:
-    item_tag_called:
-      title: "%{name} is ready"
-      body: "Please proceed to %{shop}."
+    item_tag:
+      title: "%{name}"
+      body: "%{shop}"
 
   api:
     shopkeeper:

…tifiers/item_tag_called_notifier_test.rb test/notifiers/item_tag_notifier_test.rbtest/notifiers/item_tag_called_notifier_test.rb renamed to test/notifiers/item_tag_notifier_test.rb test/notifiers/item_tag_called_notifier_test.rb renamed to test/notifiers/item_tag_notifier_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class ItemTagCalledNotifierTest < ActiveSupport::TestCase
+class ItemTagNotifierTest < ActiveSupport::TestCase
   setup do
     @shopkeeper = shopkeepers(:one)
     @shopkeeper.create_default_account
@@ -10,24 +10,24 @@ class ItemTagCalledNotifierTest < ActiveSupport::TestCase
 
   test "delivering creates a Noticed::Event" do
     assert_difference -> { Noticed::Event.count }, 1 do
-      ItemTagCalledNotifier.with(record: @item_tag).deliver(@shopkeeper)
+      ItemTagNotifier.with(record: @item_tag).deliver(@shopkeeper)
     end
   end
 
   test "delivering creates a Noticed::Notification for the recipient" do
     assert_difference -> { Noticed::Notification.count }, 1 do
-      ItemTagCalledNotifier.with(record: @item_tag).deliver(@shopkeeper)
+      ItemTagNotifier.with(record: @item_tag).deliver(@shopkeeper)
     end
     notification = @shopkeeper.notifications.last
     assert_not_nil notification
     assert_equal @item_tag, notification.record
   end
 
   test "title and body resolve from i18n on the notification" do
-    ItemTagCalledNotifier.with(record: @item_tag).deliver(@shopkeeper)
+    ItemTagNotifier.with(record: @item_tag).deliver(@shopkeeper)
     notification = @shopkeeper.notifications.last
 
-    assert_equal I18n.t("notifiers.item_tag_called.title", name: @item_tag.name), notification.title
-    assert_equal I18n.t("notifiers.item_tag_called.body", shop: @shop.name), notification.body
+    assert_equal I18n.t("notifiers.item_tag.title", name: @item_tag.name), notification.title
+    assert_equal I18n.t("notifiers.item_tag.body", shop: @shop.name), notification.body
   end
 end