Skip to content

Commit 27d462a

Browse files
committed
Fix bin/ci: rubocop trailing blank line and brakeman fingerprint refresh
- Drop the extra blank line at end of shops_controller_test.rb class body (Layout/EmptyLinesAroundClassBody, leftover from Step 7 reset action removal) - Refresh brakeman.ignore: AccountsShopkeeper::ROLES collapse changed the expanded permit() literal, so the warning fingerprint shifted. Same intentional rationale (admin-gated role assignment); only the resolved role list and fingerprint differ.
1 parent 4fe3bf9 commit 27d462a

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

config/brakeman.ignore

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
{
44
"warning_type": "Mass Assignment",
55
"warning_code": 105,
6-
"fingerprint": "5be66927ab36c68816fde998b592c1581de478fca71f02be2af0c87e0c4f0196",
6+
"fingerprint": "f4957c889683ff8d96d42c7fc267b0394ff94ae2ebd7de32c7e806e7e63017be",
77
"check_name": "PermitAttributes",
88
"message": "Potentially dangerous key allowed for mass assignment",
99
"file": "app/controllers/api/v1/shopkeeper/accounts_shopkeepers_controller.rb",
10-
"line": 57,
10+
"line": 67,
1111
"link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/",
12-
"code": "params.require(:accounts_shopkeeper).permit(:admin, :senior_manager, :junior_manager, :senior_member, :junior_member, :guest)",
12+
"code": "params.require(:accounts_shopkeeper).permit(:admin, :member)",
1313
"render_path": null,
1414
"location": {
1515
"type": "method",
@@ -24,6 +24,6 @@
2424
"note": "Intentional: role booleans are explicitly permitted for account admins to manage team member roles. Endpoint is protected by require_account_admin and require_non_personal_account! before_actions."
2525
}
2626
],
27-
"updated": "2026-03-01",
27+
"updated": "2026-04-24",
2828
"brakeman_version": "8.0.4"
2929
}

test/controllers/api/v1/shopkeeper/shops_controller_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,5 +80,4 @@ class Api::V1::Shopkeeper::ShopsControllerTest < ActionDispatch::IntegrationTest
8080

8181
assert_response :success
8282
end
83-
8483
end

0 commit comments

Comments
 (0)