Skip to content

Commit 45c18a3

Browse files
dadachiclaude
andcommitted
Fix RuboCop offenses in Active Storage migrations
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 18191b2 commit 45c18a3

2 files changed

Lines changed: 12 additions & 11 deletions

db/migrate/20260306071846_add_service_name_to_active_storage_blobs.active_storage.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ def up
66
unless column_exists?(:active_storage_blobs, :service_name)
77
add_column :active_storage_blobs, :service_name, :string
88

9-
if configured_service = ActiveStorage::Blob.service.name
9+
if (configured_service = ActiveStorage::Blob.service.name)
1010
ActiveStorage::Blob.unscoped.update_all(service_name: configured_service)
1111
end
1212

db/migrate/20260306071847_create_active_storage_variant_records.active_storage.rb

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,21 @@ def change
88
t.belongs_to :blob, null: false, index: false, type: blobs_primary_key_type
99
t.string :variation_digest, null: false
1010

11-
t.index %i[ blob_id variation_digest ], name: "index_active_storage_variant_records_uniqueness", unique: true
11+
t.index %i[blob_id variation_digest], name: "index_active_storage_variant_records_uniqueness", unique: true
1212
t.foreign_key :active_storage_blobs, column: :blob_id
1313
end
1414
end
1515

1616
private
17-
def primary_key_type
18-
config = Rails.configuration.generators
19-
config.options[config.orm][:primary_key_type] || :primary_key
20-
end
2117

22-
def blobs_primary_key_type
23-
pkey_name = connection.primary_key(:active_storage_blobs)
24-
pkey_column = connection.columns(:active_storage_blobs).find { |c| c.name == pkey_name }
25-
pkey_column.bigint? ? :bigint : pkey_column.type
26-
end
18+
def primary_key_type
19+
config = Rails.configuration.generators
20+
config.options[config.orm][:primary_key_type] || :primary_key
21+
end
22+
23+
def blobs_primary_key_type
24+
pkey_name = connection.primary_key(:active_storage_blobs)
25+
pkey_column = connection.columns(:active_storage_blobs).find { |c| c.name == pkey_name }
26+
pkey_column.bigint? ? :bigint : pkey_column.type
27+
end
2728
end

0 commit comments

Comments
 (0)