Skip to content

Commit a739a44

Browse files
committed
Drop dead queue-length config, controller meta, and test assertion
Step 17 residual sweep caught references the per-step grep missed: - config/settings.yml: drop maximum_queue_number_length and the item_tag.default_count / default_queue_number_length keys (only consumed by the removed format validator and create_default_item_tags!) - PermissionsController#index meta: drop maximum_queue_number_length (clients no longer need to enforce the queue-format length cap) - permissions_controller_test: drop the matching assertion
1 parent 29dd109 commit a739a44

3 files changed

Lines changed: 0 additions & 5 deletions

File tree

app/controllers/api/v1/shopkeeper/permissions_controller.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ def index
1717
android_app_version: current_android_app_version,
1818
should_update_privacy: should_update_privacy,
1919
should_update_terms: should_update_terms,
20-
maximum_queue_number_length: ConfigSettings.maximum_queue_number_length,
2120
shop_limit_count: ConfigSettings.shop.limit_count,
2221
account_limit_count: ConfigSettings.account.limit_count,
2322
accounts_shopkeeper_limit_count: ConfigSettings.accounts_shopkeeper.limit_count

config/settings.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ mobile_app:
2323
play_store_url: https://play.google.com/store/apps/details?id=com.yourdomain.nativeapptemplate
2424

2525
minimum_password_length: 8
26-
maximum_queue_number_length: 5
2726

2827
shop:
2928
limit_count: 99
@@ -40,5 +39,3 @@ accounts_invitation:
4039

4140
item_tag:
4241
limit_count: 99
43-
default_count: 10
44-
default_queue_number_length: 4

test/controllers/api/v1/shopkeeper/permissions_controller_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ class Api::V1::Shopkeeper::PermissionsControllerTest < ActionDispatch::Integrati
1818
assert json["meta"]["android_app_version"].present?
1919
assert_not_nil json["meta"]["should_update_privacy"]
2020
assert_not_nil json["meta"]["should_update_terms"]
21-
assert json["meta"]["maximum_queue_number_length"].present?
2221
assert json["meta"]["shop_limit_count"].present?
2322
assert json["meta"]["account_limit_count"].present?
2423
assert json["meta"]["accounts_shopkeeper_limit_count"].present?

0 commit comments

Comments
 (0)