Fixing error message on Android build#4
Open
wpatter6 wants to merge 1 commit intonativescript-vue:masterfrom
Open
Fixing error message on Android build#4wpatter6 wants to merge 1 commit intonativescript-vue:masterfrom
wpatter6 wants to merge 1 commit intonativescript-vue:masterfrom
Conversation
wpatter6
commented
Apr 23, 2019
wpatter6
commented
- Adding keys to looped elements
- Reducing util import
- Resolves issue Build on Android not working #1
Author
|
The issue was fixed by reducing the util import. The error message seemed to be pointing to an unused part of the util package. It could have instead been fixed within that package, but for now this will allow this component to be used by Android, and also somewhat reduce its size as it's not importing everything from util to call a single method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.