feat: run two passes for lightningcss to improve output#164
Merged
marklawlor merged 2 commits intomainfrom Sep 3, 2025
Merged
Conversation
marklawlor
force-pushed
the
09-03-feat_improve_rem_inlining_to_simplify_calc_
branch
from
2f91e23 to
13fb342
Compare
marklawlor
force-pushed
the
09-03-feat_improve_rem_inlining_to_simplify_calc_
branch
from
13fb342 to
b70ddef
Compare
marklawlor
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a two-pass approach for lightningcss processing to improve CSS output quality by ensuring proper calc simplification and rem unit conversion.
- Adds a first pass to handle rem-to-px conversion before the main processing
- Updates infinity handling to use JavaScript's safe integer constants instead of hardcoded values
- Fixes target reference issues in style application and selector building
Reviewed Changes
Copilot reviewed 6 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/compiler.ts | Implements two-pass lightningcss processing with rem conversion in first pass |
| src/compiler/declarations.ts | Updates infinity handling to use safe integer constants and adds rounding to time parsing |
| src/compiler/selector-builder.ts | Moves root and specificity declarations inside the loop to avoid reference issues |
| src/runtime/native/styles/calculate-props.ts | Adds target reference preservation to prevent style application issues |
| src/tests/native/calc.test.tsx | Updates test expectation to match new safe integer infinity handling |
| src/tests/compiler/compiler.test.tsx | Adds test for rem simplification functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marklawlor
deleted the
09-03-feat_improve_rem_inlining_to_simplify_calc_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.